-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dlib: 19.9 -> 19.10 #39255
dlib: 19.9 -> 19.10 #39255
Conversation
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/dlib/versions. These checks were done: - built on NixOS - Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.) - found 19.10 with grep in /nix/store/1rrcrcghnbimsn8rn7viyapsczw93vs8-dlib-19.10 - directory tree listing: https://gist.github.com/227f969f6d6122a323fabf28fff29dd7
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: dlib Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: dlib Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: dlib Partial log (click to expand)
|
@GrahamcOfBorg build python2.pkgs.face_recognition python3.pkgs.face_recognition |
Failure on x86_64-linux (full log) Attempted: python2.pkgs.face_recognition, python3.pkgs.face_recognition Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: python2.pkgs.face_recognition, python3.pkgs.face_recognition Partial log (click to expand)
|
Build failures looks serious. Someone should check first if it is related to this update. |
Maybe @Ma27 can have a look. |
thx for the notification, I can have a look at it tonight %) |
@dotlambda @Mic92 the last time @ryantm attempted a package bump the same thing happened (and dlib 19.9 on nixpkgs master works perfectly fine). IIRC @dotlambda did some investigation and found the patch which caused the issue. However I somehow forgot about this (sorry :/). In the end I'd keep this on hold until we managed to fix the build errors related to |
I'm quite sure that this the broken tests are realated to FROM python:3
RUN apt-get update && apt-get install -y cmake libopenblas-dev libpng-dev libjpeg-dev git
RUN pip install pytest
RUN git clone https://github.com/davisking/dlib /build-env
WORKDIR /build-env
RUN python setup.py test However when I clone I'm not yet sure what the cause is, but I suspect that it's some kind of incompatibility between several libraries. However I'll be busy today, I surely hope to do some furhter investigation tonight though :-) |
It seems like something similar is happening e.g. here: https://hydra.nixos.org/build/72836676/nixlog/1 |
It seems as the commit 9691c194 (which introduces variadic function support for However I don't know enough about our current Python setup in |
This fixes the latest `dlib` build for `nixpkgs` compliancy: * Patched `setup.py` to use number of jobs defined in `$NIX_BUILD_CORES` rather than using all available cores. * Bumped `dlib` to latest version (v19.13 ATM). * Dropped `openblas` build input, `cblas` which actually works lives in `dlib/external`. Otherwise the test suite runs into segfaults (see NixOS#39255 (comment) for further reference). * Added myself as maintainer in case of any further breakage in the future. Closes NixOS#39255 /cc @dotlambda @ryantm
This fixes the latest `dlib` build for `nixpkgs` compliancy: * Patched `setup.py` to use number of jobs defined in `$NIX_BUILD_CORES` rather than using all available cores. * Bumped `dlib` to latest version (v19.13 ATM). * Dropped `openblas` build input, `cblas` which actually works lives in `dlib/external`. Otherwise the test suite runs into segfaults (see #39255 (comment) for further reference). * Added myself as maintainer in case of any further breakage in the future. Closes #39255 /cc @dotlambda @ryantm
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/dlib/versions.
These checks were done:
cc @christopherpoole for review