-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eff: 20140928 -> 5.0 #39264
eff: 20140928 -> 5.0 #39264
Conversation
Success on x86_64-linux (full log) Attempted: eff Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: eff Partial log (click to expand)
|
Tests fixes can be backported with |
url = "https://github.com/matijapretnar/eff.git"; | ||
rev = "90f884a790fddddb51d4d1d3b7c2edf1e8aabb64"; | ||
sha256 = "0cqqrpvfw0nrk5d28mkzfvc8yzqxcss0k46bkmqhqjkqq886n2mm"; | ||
src = fetchzip { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchFromGithub
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has the same semantics, but is it is mainly about consistency with the code base. We also have some tooling that looks for fetchFromGithub
and interfere additional information.
Updated to use I don’t think the tests need fixing: their failure shows a problem with the tests, not with the software under test. |
Success on x86_64-linux (full log) Attempted: eff Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: eff Partial log (click to expand)
|
Motivation for this change
Update to a released version.
Note that two tests fail, but that seems expected. This has been recently fixed upstream (matijapretnar/eff@be7442d) but not released yet.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)