Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gup: simplify build expression #39324

Merged
merged 2 commits into from
Apr 22, 2018
Merged

gup: simplify build expression #39324

merged 2 commits into from
Apr 22, 2018

Conversation

timbertson
Copy link
Contributor

Motivation for this change

The original build script is a bit weird, as it was split into a separate default.nix and build.nix. I've figured out a way to make it idiomatic and still reuse the same file upstream (https://github.com/timbertson/gup/blob/55d4fce3ce390f678e99d45fc8fa683666fde96c/nix/gup-python.nix).

Also added an updateScript for automating updates

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants