nixos/tests/keymap: wait for xdotool to succeed

[xeji]

Motivation for this change

After merging #39400 we hit another non-deterministic failure: xdotool could fail when a new window was already created but not yet decorated by the window manager (thanks @srhb for catching on to this).

Fix this by waiting for xdotool to succeed. Also prevent a never observed but possible race condition elsewhere in the code.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[xeji]

@GrahamcOfBorg test keymap.dvorak

[srhb]

@xeji Please PR adding yourself to this list: 😄 https://github.com/NixOS/ofborg/blob/released/config.public.json

[srhb]

@GrahamcOfBorg test keymap.dvorak

[srhb]

Oh sorry, I see you're already in known users. I didn't see the eval start on the monitor. :-)

[GrahamcOfBorg]

Failure on aarch64-linux (full log)

Attempted: tests.keymap.dvorak

Partial log (click to expand)

cannot build derivation '/nix/store/2ziylmi49xnl5aabqrkp4kb1r29m96jr-etc.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kdg66d86l6nbswjblgydsb4h7c86dkrs-stage-1-init.sh.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mz477nswb8ykyqxl8gmkd0jy59y58bn5-initrd.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/xppcvna7iwmy2f4wwxq2w5c022f2pfs1-nixos-system-machine-18.09.git.8f73b1f.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/1xxaix7d2rl2bv5f8445q70lrzihmm1z-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/8vc9psm3m47dqphgki0nnw2ggbn0ckwp-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/95l1bfy6chn28gm6h6cb2hyqyc6i68d8-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/vy2fra8z4jik0cgc4j64dfwzhbkzdm4z-nixos-test-driver-keymap-dvorak.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/zd5hh8zis0kc40vwibrk0hk39d6sb19j-vm-test-run-keymap-dvorak.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/zd5hh8zis0kc40vwibrk0hk39d6sb19j-vm-test-run-keymap-dvorak.drv' failed

[xeji]

Looks unrelated. Are the tests supposed to work on aarch64 now? I've never seen one succeed.

[srhb]

No, I think that failure is fine.

[GrahamcOfBorg]

Failure on aarch64-linux (full log)

Attempted: tests.keymap.dvorak

Partial log (click to expand)

cannot build derivation '/nix/store/g2psf8cpvdj7l15hxfgj5vd2gf145y08-etc.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kdg66d86l6nbswjblgydsb4h7c86dkrs-stage-1-init.sh.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mz477nswb8ykyqxl8gmkd0jy59y58bn5-initrd.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/i6w768pnyr6sx9v73v3wi5jlpbqh28jf-nixos-system-machine-18.09.git.f74e791.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/4blx75kgh8vngr3c5fy0lr6sxyigkfa6-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/r2rl94j26plsm2xcwdza4xqdik7qw36c-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/89yw8p3imnmqp8ny40ca22bh12sadalj-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/a83h4j8szr4s55ynzlhxq66vjynzia49-nixos-test-driver-keymap-dvorak.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/k4rb353r4ddkjq66gvd5dns0ypsffzcg-vm-test-run-keymap-dvorak.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/k4rb353r4ddkjq66gvd5dns0ypsffzcg-vm-test-run-keymap-dvorak.drv' failed

[xeji]

ofborg dashboard says x86_64-linux builder is stalled, this may take a while or time out.

[srhb]

I built it locally just fine. How about I merge it to master and we track its progress on Hydra, reopen the ticket and track it for merging to release once we have confidence?

[GrahamcOfBorg]

Success on x86_64-linux (full log)

Attempted: tests.keymap.dvorak

Partial log (click to expand)

syncing
machine: running command: sync
machine: exit status 0
2 out of 2 tests succeeded
test script finished in 25.02s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/hjdlibmf773jhbx3sq18xk3b7n0ahiar-vm-test-run-keymap-dvorak

[GrahamcOfBorg]

Success on x86_64-linux (full log)

Attempted: tests.keymap.dvorak

Partial log (click to expand)

/nix/store/hjdlibmf773jhbx3sq18xk3b7n0ahiar-vm-test-run-keymap-dvorak