Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sacrifice: fix runtime on darwin #39503

Merged
merged 1 commit into from
Apr 25, 2018
Merged

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Apr 25, 2018

Motivation for this change

Fixes following error:

dyld: Library not loaded: @rpath/libpythia8.dylib
  Referenced from: /nix/store/xxxxx-sacrifice-1.0.0/bin/run-pythia
  Reason: image not found
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: sacrifice

Partial log (click to expand)

make[2]: Entering directory '/private/tmp/nix-build-sacrifice-1.0.0.drv-0/Sacrifice-1.0.0'
make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-sacrifice-1.0.0.drv-0/Sacrifice-1.0.0'
make[1]: Leaving directory '/private/tmp/nix-build-sacrifice-1.0.0.drv-0/Sacrifice-1.0.0'
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/vj9swj39jn82jn08sxdsibmvg2yfdgg5-sacrifice-1.0.0/lib  /nix/store/vj9swj39jn82jn08sxdsibmvg2yfdgg5-sacrifice-1.0.0/bin
patching script interpreter paths in /nix/store/vj9swj39jn82jn08sxdsibmvg2yfdgg5-sacrifice-1.0.0
/nix/store/vj9swj39jn82jn08sxdsibmvg2yfdgg5-sacrifice-1.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sacrifice

Partial log (click to expand)

make[1]: Leaving directory '/build/Sacrifice-1.0.0'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/iiq8cdz07rvlqngl9bm7nrv1giisgpxi-sacrifice-1.0.0
shrinking /nix/store/iiq8cdz07rvlqngl9bm7nrv1giisgpxi-sacrifice-1.0.0/lib/SacrificePlugin.so.0.0.0
shrinking /nix/store/iiq8cdz07rvlqngl9bm7nrv1giisgpxi-sacrifice-1.0.0/bin/run-pythia
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/iiq8cdz07rvlqngl9bm7nrv1giisgpxi-sacrifice-1.0.0/lib  /nix/store/iiq8cdz07rvlqngl9bm7nrv1giisgpxi-sacrifice-1.0.0/bin
patching script interpreter paths in /nix/store/iiq8cdz07rvlqngl9bm7nrv1giisgpxi-sacrifice-1.0.0
checking for references to /build in /nix/store/iiq8cdz07rvlqngl9bm7nrv1giisgpxi-sacrifice-1.0.0...
/nix/store/iiq8cdz07rvlqngl9bm7nrv1giisgpxi-sacrifice-1.0.0

@Mic92 Mic92 merged commit 18da50d into NixOS:master Apr 25, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sacrifice

Partial log (click to expand)

these paths will be fetched (15.85 MiB download, 70.50 MiB unpacked):
  /nix/store/5y0lwlkpq1a5bxz512ll2hj1cbwm1vxh-sacrifice-1.0.0
  /nix/store/bimnyrrwbcj8552ayg7g704mmdxpkc1d-pythia-8.226
copying path '/nix/store/bimnyrrwbcj8552ayg7g704mmdxpkc1d-pythia-8.226' from 'https://cache.nixos.org'...
copying path '/nix/store/5y0lwlkpq1a5bxz512ll2hj1cbwm1vxh-sacrifice-1.0.0' from 'https://cache.nixos.org'...
/nix/store/5y0lwlkpq1a5bxz512ll2hj1cbwm1vxh-sacrifice-1.0.0

@veprbl veprbl deleted the pr/sacrifice_darwin_fix branch December 1, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants