Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkd: Allow RequiredForOnline field in [Link] section #39613

Merged
merged 1 commit into from
Apr 27, 2018
Merged

networkd: Allow RequiredForOnline field in [Link] section #39613

merged 1 commit into from
Apr 27, 2018

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Apr 27, 2018 •
edited
Loading

Motivation for this change

This was previously missing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 27, 2018
@bgamari
Copy link
Contributor Author

bgamari commented Apr 27, 2018

Pinging @edolstra.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Apr 27, 2018
@Mic92 Mic92 merged commit 91e58ad into NixOS:master Apr 27, 2018
alexshpilkin
alexshpilkin reviewed Jul 23, 2018
View reviewed changes
nixos/modules/system/boot/networkd.nix
])
(assertMacAddress "MACAddress")
(assertByteFormat "MTUBytes")
(assertValueOneOf "ARP" boolValues)
(assertValueOneOf "Unmanaged" boolValues)
(assertValueOneOf "RquiredForOnline" boolValues)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 @bgamari I’m sure this should’ve been RequiredForOnline, with an e. (Given that total my experience with Nix is about six hours, I don’t know why or whether it builds with the typo. Sorry for not writing a patch.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshpilkin alexshpilkin alexshpilkin left review comments

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bgamari @alexshpilkin @Mic92 @GrahamcOfBorg