build-fhs-chrootenv: bind mount chroots /tmp to hosts /tmp #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok. I just integrated it! |
svanderburg
added a commit
that referenced
this pull request
Sep 9, 2014
build-fhs-chrootenv: bind mount chroots /tmp to hosts /tmp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@svanderburg here is the /tmp related, rebased & checked change to build-fhs-chrootenv as mentioned in #2355
The patch handles how /tmp is handled in build-fhs-chrootenv. Till now it just created a tmp subdirectory within /run. /run lies in memory therefore the chroots /tmp will reside there as well, this triggers two problems 1) the hosts memory is limited and this will also limit the /tmp size of the chroot (this is very bad for example graphical applications) 2) you ram will get polluted leaving you with less bang for your apps.
With the patch applied it will create a directory within the hosts /tmp and will then mount the chroot's /tmp to this newly created directory. So the chroot's /tmp will use the same capabilities and optimizations as the host's does.