ansible: update point releases and unify build #40277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on x86_64-linux (full log) Attempted: ansible Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: ansible Partial log (click to expand)
|
Mic92
reviewed
May 10, 2018
pkgs/tools/admin/ansible/default.nix
Outdated
| }; | ||
|
|
||
| in rec { | ||
| # I really don't know why we carry so many versions... |
There was a problem hiding this comment.
We should only have the official supported releases here, which is 2.4 and 2.5 https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html?highlight=release#release-status
Mic92
reviewed
May 10, 2018
| sha256 = "1r9sq30xz3jrvx6yqssj5wmkml1f75rx1amd7g89f3ryngrq6m59"; | ||
| }; | ||
|
|
||
| ansible2 = ansible_2_5; |
There was a problem hiding this comment.
Should be 2.4. 2.5 is still in development.
There was a problem hiding this comment.
Are you 100% sure? 2.5 looks to be the stable release version on https://docs.ansible.com where 2.4 is listed as a "previous version".
|
Could a second commit be added that removes the old versions? |
Done |
|
Success on x86_64-linux (full log) Attempted: ansible Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: ansible Partial log (click to expand)
|
xeji
reviewed
May 10, 2018
| # We will carry all the supported versions | ||
|
|
||
| ansible_2_4 = generic { | ||
| version = "2.4.4.0"; |
There was a problem hiding this comment.
This will build 2.4 with python3. Ansible doc says:
Ansible 2.5 and above have support for Python 3. Previous to 2.5, the Python 3 support was considered a tech preview.
Do we want to use python3 here anyway although it's not officially supported?
There was a problem hiding this comment.
Version 2.1 built properly with python3 when I tried.
There was a problem hiding this comment.
I'm not saying it doesn't work - it's just not officially supported. It was more of a question whether we want to package a "tech previer".
There was a problem hiding this comment.
Turns out that previously all of them were built with python2, so in order not to change too much at one time, I'll change it to that here as well.
1) We had lots of copy paste - instead use a generic builder for the various reasons. 2) Default version changed to latest (2.5 instead of 2.4) 3) Point release updates to all
|
Success on aarch64-linux (full log) Attempted: ansible Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: ansible Partial log (click to expand)
|
|
@GrahamcOfBorg build ansible ansible_2_4 |
|
Success on x86_64-linux (full log) Attempted: ansible, ansible_2_4 Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: ansible, ansible_2_4 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: ansible, ansible_2_4 Partial log (click to expand)
|
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We had lots of copy paste - instead use a generic builder for the various versions.
Default version changed to latest (2.5 instead of 2.4) - ref Update default attributes to latest version available #40015
Point release updates for all versions
Cc: @jgeerds @joamaki
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)