Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nat to leverage the firewall unit if available #4111

Merged
merged 2 commits into from
Sep 16, 2014

Conversation

wkennington
Copy link
Contributor

No description provided.

wkennington added a commit that referenced this pull request Sep 16, 2014
Allow nat to leverage the firewall unit if available
@wkennington wkennington merged commit 0b58662 into NixOS:master Sep 16, 2014
@aristidb
Copy link
Contributor

If you merge them a minute after creating them, there's little point in
creating PRs. Nobody looks at closed PRs.
Am 16.09.2014 06:33 schrieb "William A. Kennington III" <
notifications@github.com>:

Merged #4111 #4111.


Reply to this email directly or view it on GitHub
#4111 (comment).

@wmertens
Copy link
Contributor

No, PRs are nice even when you immediately pull them. I saw the email and came here.

Post-merge 👍 😀

One thing though - I notice that this completely flushes the nat table, instead of using its own chain like the regular firewall does. This is what it did before, but it would be nice if the rules were in their own chain so e.g. Docker and friends don't get their firewall rules deleted by this.

@lucabrunox
Copy link
Contributor

@wmertens I can agree with things like packages, but not with system stuff if overlooked breaks nixos deployments. Let other people take time to review this critical stuff.

@wkennington
Copy link
Contributor Author

@wmertens #4121 Should implement that behavior.

@GTrunSec GTrunSec mentioned this pull request Feb 20, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants