-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spotify: 1.0.79.223.g92622cc2-21 -> 1.0.80.480.g51b03ac3-13 #41356
Conversation
Version 1.0.79.223.g92622cc2-21 doesn't exists in [spotify](https://repository-origin.spotify.com/pool/non-free/s/spotify-client/) repository, so i updated it to exists version
Are you sure that you don't need to update the sha256 of this? https://github.com/NixOS/nixpkgs/pull/41356/files#diff-ece7f62a737100ec76df43623faba00aR54
If you have the old hash of the package in your store, nix will use that regardless if you change the version number. And secondly it would be nice if you amended your commit to say: |
@aprokurov And then squash your two commits into one with the commit title |
And just the squashing of the two commits to follow the guidelines of commit messages left: https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes |
@GrahamcOfBorg build spotify |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: spotify Partial log (click to expand)
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: spotify Partial log (click to expand)
|
Version 1.0.79.223.g92622cc2-21 doesn't exists in [spotify](https://repository-origin.spotify.com/pool/non-free/s/spotify-client/) repository, so i updated it to exists version (cherry picked from commit 44b52c1)
backported in 59a56cd |
* master: (25 commits) prosody: 0.10.1 -> 0.10.2 mpd: fix spelling in description pulseaudio-ctl: init at 1.66 qt: remove install_name_tool stuff multimc: 0.6.1 -> 0.6.2 lib: test for bitAnd, bitOr, bitXor pandas: fix check with the current pytest qt: fixup from c4cac55 calibre: 2.24.1 -> 2.25.0 spotify: 1.0.79.223.g92622cc2-21 -> 1.0.80.480.g51b03ac3-13 (#41356) libbsd-freedesktop: re-init at 0.9.1, use for samba sbt: 1.1.4 -> 1.1.6 nixos/slurm: remove propagatedBuidInputs from slurmWrapped gitkraken: 3.6.1 -> 3.6.3 pass-import: export PREFIX, set PASSWORD_STORE_BIN pass: Add pass-audit extension slurm: add maintainer nixos/slurm: update test, add test for enableStools slurm: add freeipmi, readline, libssh2, fix hwloc nixos/slurm: Add man pages to wrapedSlurm ...
Motivation for this change
Version 1.0.79.223.g92622cc2-21 doesn't exists in spotify repository, so i decided to update it to exists version
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)