Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tt-rss: Support plugins and themes #41444

Merged
merged 1 commit into from
Jun 29, 2018
Merged

nixos/tt-rss: Support plugins and themes #41444

merged 1 commit into from
Jun 29, 2018

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Jun 4, 2018

Motivation for this change

I'd like to use another theme and to authenticate against LDAP. This means both a theme and a plugin is required.
Also, the LDAP plugin is configured via config.php, so I added extraConfig.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dasJ
nixos/tt-rss: Support plugins and themes
31714e4 
The extra config is required to configure some plugins.
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jun 4, 2018
@dasJ
Copy link
Member Author

dasJ commented Jun 28, 2018

Ping @gebner

@matthewbauer matthewbauer merged commit 76d1e13 into NixOS:master Jun 29, 2018
@gebner
Copy link
Member

gebner commented Jun 29, 2018

lgtm, also cc @globin @zohl

@dasJ dasJ deleted the tt-rss branch June 30, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dasJ @gebner @matthewbauer @GrahamcOfBorg