-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixcw : init at 3.5.1 #41747
unixcw : init at 3.5.1 #41747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please squash your commits into one commit.
name = "unixcw-${version}"; | ||
version = "3.5.1"; | ||
src = fetchurl { | ||
url = mirror://sourceforge/unixcw/unixcw_3.5.1.orig.tar.gz; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use ${version} in the URL so the package can be updated more easily.
sha256 ="5f3aacd8a26e16e6eff437c7ae1e9b389956fb137eeb3de24670ce05de479e7a"; | ||
}; | ||
patches = [ | ||
./remove-use-of-dlopen.patch.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gzipping this patch seems excessive to me; how about we just have the .patch file unzipped.
Hi Ryan, Thanks for looking at my pull request. I'm still new to this. (Update: Found out myself ! : git push --force) |
@GrahamcOfBorg build unixcw |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: unixcw Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: unixcw Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: unixcw Partial log (click to expand)
|
Motivation for this change
I would like to add the unixcw package to nixpkgs
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)