Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixcw : init at 3.5.1 #41747

Merged
merged 1 commit into from
Jun 10, 2018
Merged

unixcw : init at 3.5.1 #41747

merged 1 commit into from
Jun 10, 2018

Conversation

MarcFontaine
Copy link
Contributor

Motivation for this change

I would like to add the unixcw package to nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please squash your commits into one commit.

name = "unixcw-${version}";
version = "3.5.1";
src = fetchurl {
url = mirror://sourceforge/unixcw/unixcw_3.5.1.orig.tar.gz;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ${version} in the URL so the package can be updated more easily.

sha256 ="5f3aacd8a26e16e6eff437c7ae1e9b389956fb137eeb3de24670ce05de479e7a";
};
patches = [
./remove-use-of-dlopen.patch.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gzipping this patch seems excessive to me; how about we just have the .patch file unzipped.

@MarcFontaine
Copy link
Contributor Author

MarcFontaine commented Jun 9, 2018

Hi Ryan,

Thanks for looking at my pull request. I'm still new to this.
Is it possible to update a pull request with a squashed commit
or to I have to close this pull request and open a new one?

(Update: Found out myself ! : git push --force)

@ryantm
Copy link
Member

ryantm commented Jun 10, 2018

@GrahamcOfBorg build unixcw

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: unixcw

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: unixcw

Partial log (click to expand)

shrinking /nix/store/z28slb8zadw796n7hmg7vx16a2sjzfmn-unixcw-3.5.1/bin/cwgen
shrinking /nix/store/z28slb8zadw796n7hmg7vx16a2sjzfmn-unixcw-3.5.1/bin/cw
shrinking /nix/store/z28slb8zadw796n7hmg7vx16a2sjzfmn-unixcw-3.5.1/lib/libcw.so.6.6.1
gzipping man pages under /nix/store/z28slb8zadw796n7hmg7vx16a2sjzfmn-unixcw-3.5.1/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z28slb8zadw796n7hmg7vx16a2sjzfmn-unixcw-3.5.1/lib  /nix/store/z28slb8zadw796n7hmg7vx16a2sjzfmn-unixcw-3.5.1/bin
patching script interpreter paths in /nix/store/z28slb8zadw796n7hmg7vx16a2sjzfmn-unixcw-3.5.1
checking for references to /build in /nix/store/z28slb8zadw796n7hmg7vx16a2sjzfmn-unixcw-3.5.1...
postPatchMkspecs
/nix/store/z28slb8zadw796n7hmg7vx16a2sjzfmn-unixcw-3.5.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: unixcw

Partial log (click to expand)

shrinking /nix/store/rlnyxyhfinmxk59jdasi7rrmx8k54xb7-unixcw-3.5.1/bin/cwgen
shrinking /nix/store/rlnyxyhfinmxk59jdasi7rrmx8k54xb7-unixcw-3.5.1/bin/cw
shrinking /nix/store/rlnyxyhfinmxk59jdasi7rrmx8k54xb7-unixcw-3.5.1/lib/libcw.so.6.6.1
gzipping man pages under /nix/store/rlnyxyhfinmxk59jdasi7rrmx8k54xb7-unixcw-3.5.1/share/man/
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rlnyxyhfinmxk59jdasi7rrmx8k54xb7-unixcw-3.5.1/lib  /nix/store/rlnyxyhfinmxk59jdasi7rrmx8k54xb7-unixcw-3.5.1/bin
patching script interpreter paths in /nix/store/rlnyxyhfinmxk59jdasi7rrmx8k54xb7-unixcw-3.5.1
checking for references to /build in /nix/store/rlnyxyhfinmxk59jdasi7rrmx8k54xb7-unixcw-3.5.1...
postPatchMkspecs
/nix/store/rlnyxyhfinmxk59jdasi7rrmx8k54xb7-unixcw-3.5.1

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild and removed 10.rebuild-darwin: 1-10 labels Jun 10, 2018
@matthewbauer matthewbauer merged commit 83be4ee into NixOS:master Jun 10, 2018
@MarcFontaine MarcFontaine deleted the unixcw branch June 12, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants