Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atom: 1.27.2 -> 1.28.0 #42425

Merged
merged 1 commit into from
Jun 23, 2018
Merged

atom: 1.27.2 -> 1.28.0 #42425

merged 1 commit into from
Jun 23, 2018

Conversation

Synthetica9
Copy link
Member

Motivation for this change

New version 🎉

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jun 23, 2018

@GrahamcOfBorg build atom

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: atom

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: atom

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: atom

Partial log (click to expand)

/nix/store/arswgi8l1hf9wjli6z3z8l8baz5rcdr6-atom-1.28.0/share/atom/resources/app/apm/node_modules/ajv/scripts/travis-gh-pages: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/arswgi8l1hf9wjli6z3z8l8baz5rcdr6-atom-1.28.0/share/atom/resources/app/apm/node_modules/ajv/scripts/prepare-tests: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/arswgi8l1hf9wjli6z3z8l8baz5rcdr6-atom-1.28.0/share/atom/resources/app/apm/node_modules/open/vendor/xdg-open: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/arswgi8l1hf9wjli6z3z8l8baz5rcdr6-atom-1.28.0/share/atom/resources/app/apm/script/postinstall.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/arswgi8l1hf9wjli6z3z8l8baz5rcdr6-atom-1.28.0/share/atom/resources/app/atom.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/arswgi8l1hf9wjli6z3z8l8baz5rcdr6-atom-1.28.0...
cannot find section .dynamic
file /nix/store/arswgi8l1hf9wjli6z3z8l8baz5rcdr6-atom-1.28.0/share/atom/atom had a PT_GNU_STACK program header, converted
file /nix/store/arswgi8l1hf9wjli6z3z8l8baz5rcdr6-atom-1.28.0/share/atom/resources/app/apm/bin/node had a PT_GNU_STACK program header, converted
/nix/store/arswgi8l1hf9wjli6z3z8l8baz5rcdr6-atom-1.28.0

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Jun 23, 2018
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: atom

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: atom

Partial log (click to expand)

/nix/store/arswgi8l1hf9wjli6z3z8l8baz5rcdr6-atom-1.28.0

@FRidh FRidh merged commit 294e7b1 into NixOS:master Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants