Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: replace search.cpan.org with metacpan.org #43315

Merged
merged 1 commit into from
Jul 15, 2018
Merged

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Jul 11, 2018

@ryantm
Copy link
Member Author

ryantm commented Jul 11, 2018

I didn't update pkgs/development/perl-modules/expression-generator/ which was edited or created? by @7c6f434c

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jul 11, 2018
@7c6f434c
Copy link
Member

7c6f434c commented Jul 11, 2018 via email

@xeji
Copy link
Contributor

xeji commented Jul 11, 2018

cc @volth

@xeji
Copy link
Contributor

xeji commented Jul 11, 2018 via email

@ryantm
Copy link
Member Author

ryantm commented Jul 11, 2018

I prefer @volth's solution, but let's use https.

@ryantm ryantm force-pushed the cpan branch 2 times, most recently from f0a4190 to 4ae6ced Compare July 12, 2018 02:35
@ryantm
Copy link
Member Author

ryantm commented Jul 12, 2018

Can you check the new commit @volth?

@ryantm
Copy link
Member Author

ryantm commented Jul 12, 2018

@volth Okay, what I have now works, but it seems kind of ugly to me. What do you think?

@ryantm
Copy link
Member Author

ryantm commented Jul 12, 2018

@volth Yes, that seems nicer!

@xeji
Copy link
Contributor

xeji commented Jul 14, 2018

now should this go to master or staging?

https://www.perl.com/article/saying-goodbye-to-search-cpan-org/

maybe one operation less

..with unifying recursiveUpdate and first //

although not tested

fix whitespace
@ryantm ryantm changed the base branch from master to staging July 15, 2018 01:53
@ryantm
Copy link
Member Author

ryantm commented Jul 15, 2018

@volth I incorporated your patch and switched the PR over to staging

@xeji xeji merged commit 0ef2389 into NixOS:staging Jul 15, 2018
@ryantm ryantm deleted the cpan branch July 15, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants