Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.js_of_ocaml: 3.1.0 -> 3.2.0 #43535

Merged
merged 6 commits into from
Jul 21, 2018
Merged

ocamlPackages.js_of_ocaml: 3.1.0 -> 3.2.0 #43535

merged 6 commits into from
Jul 21, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jul 14, 2018

Motivation for this change

Compatibility with OCaml 4.07

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vbgl vbgl added 8.has: package (update) This PR updates a package to a newer version 6.topic: ocaml labels Jul 14, 2018
@vbgl vbgl merged commit df6534d into NixOS:master Jul 21, 2018
@vbgl vbgl deleted the ocaml-js_of_ocaml-3.2.0 branch July 21, 2018 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbgl @GrahamcOfBorg