Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/avahi: add support for extraConfig #44061

Merged
merged 1 commit into from
Jul 29, 2018
Merged

nixos/avahi: add support for extraConfig #44061

merged 1 commit into from
Jul 29, 2018

Conversation

ljani
Copy link
Contributor

@ljani ljani commented Jul 24, 2018

Motivation for this change

Allow setting additional options for avahi-daemon.conf.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jul 24, 2018
@infinisil
Copy link
Member

Can you change the commit message to use the "nixos/avahi" prefix? Looks good to me :)

@ljani
Copy link
Contributor Author

ljani commented Jul 28, 2018

@infinisil Done. Thanks for the clear up, I was indeed a little confused by the module and pkg-name separation when I took a peek what the other committers had done.

@ljani ljani changed the title avahi: add support for extraConfig nixos/avahi: add support for extraConfig Jul 28, 2018
@infinisil infinisil merged commit c3f00f7 into NixOS:master Jul 29, 2018
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants