-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ams-lv2: use python3 #44412
ams-lv2: use python3 #44412
Conversation
It is python3-compatible since 1.1.5.
Failure on aarch64-linux (full log) Attempted: ams-lv2 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: ams-lv2 Partial log (click to expand)
|
The failure on aarch64 was there before: https://hydra.nixos.org/job/nixpkgs/trunk/ams-lv2.aarch64-linux. |
|
||
configurePhase = "python waf configure --prefix=$out"; | ||
configurePhase = "${python3.interpreter} waf configure --prefix=$out"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just change python -> python3
? These lines looked better before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because absolute paths are always better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, for example, someone might want to replace python3
by a different implementation like pypy
, which does not provide the python
executable afaik.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah alright, the second reason is one I can live with :)
It is python3-compatible since 1.1.5.
Motivation for this change
#18185
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)cc @cillianderoiste
Note that this was not tested.