Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vim appears no longer to be built with GUI #44440

Closed
8573 opened this issue Aug 4, 2018 · 7 comments
Closed

Vim appears no longer to be built with GUI #44440

8573 opened this issue Aug 4, 2018 · 7 comments
Labels
0.kind: regression Something that worked before working no longer 6.topic: vim

Comments

@8573
Copy link
Contributor

8573 commented Aug 4, 2018

Issue description

nixpkgs's Vim packages appear no longer to be built with GUI support. Packages affected include vim, uncustomized vim_configurable, and customized vim_configurable, even if the last has its gui parameter explicitly set (vim_configurable.override {gui = "gtk3";}).

Steps to reproduce

nix-build '<nixpkgs>' -A vim
./result/bin/vim -g

Technical details

  • system: "x86_64-linux"
  • host os: Linux 4.14.48, NixOS, 18.09pre147850.2428f5dda13 (Jellyfish)
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.0.4
  • channels(root): "nixos-18.09pre147850.2428f5dda13"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos
@8573
Copy link
Contributor Author

8573 commented Aug 4, 2018

I see that that "gui parameter" has been renamed to guiSupport.

vim_configurable.override {guiSupport = "gtk2";} and vim_configurable.override {guiSupport = "gtk3";} both seem to have GUI support, but I'll leave this open unless it was intentional to drop GUI support from non-overridden vim_configurable.

@FRidh
Copy link
Member

FRidh commented Aug 4, 2018

This is potentially a regression of #43886. If any behavior changes, please open a PR.

@FRidh FRidh added 6.topic: vim 0.kind: regression Something that worked before working no longer labels Aug 4, 2018
@7c6f434c
Copy link
Member

7c6f434c commented Aug 5, 2018

It is indeed a behaviour change that vimHugeX as defined stopped providing a huge Vim with some X11 GUI.

@7c6f434c
Copy link
Member

7c6f434c commented Aug 5, 2018

@FRidh Should guiSupport be re-enabled at the vimHugeX or vim_configurable level?

@LnL7
Copy link
Member

LnL7 commented Aug 5, 2018

I thought this was kind of intentional. We should cleanup the options a bit more but probably best to do one thing at a time.

@7c6f434c
Copy link
Member

7c6f434c commented Aug 5, 2018

Well, having a vim huge is a good idea in my opinion, and @FRidh implied that vim_configurable was not supposed to change too much this time. Next step is probably some choice for the default size, and doing something about vimNoX (should it be built from an old fork?) and moving some costlier options to vimHugeX proper. I am not going to use a non-huge vim anyway, though…

@FRidh
Copy link
Member

FRidh commented Aug 5, 2018

@FRidh implied that vim_configurable was not supposed to change too much this time

Any changes functionally I consider regressions. What is done with them I leave to the community that uses it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: regression Something that worked before working no longer 6.topic: vim
Projects
None yet
Development

No branches or pull requests

4 participants