-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[staging]: texlive: 2017 -> 2018 #45432
Conversation
name = "texlive-poppler-0.64.patch"; | ||
url = https://git.archlinux.org/svntogit/packages.git/plain/trunk/texlive-poppler-0.64.patch?h=packages/texlive-bin; | ||
sha256 = "0443d074zl3c5raba8jyhavish706arjcd80ibb84zwnwck4ai0w"; | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you add the extra whitespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That wasn't intentional, maybe my editor's autoindent. Will clean it up before this is merged.
Hmm, tried building a collection of papers and slides and ran into this:
(but only after pulling down many many packages first) I seem to recall hashes change "quickly" (mentioned somewhere in these expressions)--is that what's going on here, or a missed hash? (or? hehe). Thanks for working on this, I can at least help test a bit! ^_^ |
These packages are being grabbed from the 2017 mirror, I think we need a new one? |
@dtzWill it doesn't work yet because I haven't pushed the update for the package download URLs yet |
Oh, okay! In that case I guess I'd like to report everything is working as expected! ;) LMK when some testing would be useful, sorry for the noise! |
... just pushed the missing commit. |
@@ -24,15 +24,15 @@ let | |||
# FIXME: a proper mirror, though tarballs.nixos.org saves this case ATM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC tarballs.nixos.org does not add everything automatically to the content-address source store; a maintainer has to run this:
https://github.com/NixOS/nixpkgs/blob/master/maintainers/scripts/copy-tarballs.pl
Finding broken/moved tarballs should be easier now, because we're using upstream's sha512
hashes as published on CTAN instead of adding the layer of indirection to download -> verify -> re-hash with sha1
; but nevertheless it'd be nice to have the ability to fetch the missing source tarballs from Hydra!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC the script doesn't work on texlive, because we don't use pure fetching (we unpack, modify a bit, and fix hash of the result).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sources for the binary in this file (bin.nix
) should be ok, they are archived by release date and should be stable enough.
The issue is with the thousands of package source tarballs (see default.nix
), which are not under version control. For packages, the upstream package database file and our generated pkgs.nix
now both use unmodified sha512
hashes of the downloaded .tar.xz
files - so maybe uploading them to tarballs.nixos.org
could work now?
Thanks for carrying the torch on this one @xeji! I'm having some issues compiling
IIRC this one isn't too big for the bot to build (plus everyone should be asleep now anyways). Let's see: @GrahamcOfBorg build texlive.bin EDIT: Hmm, I guess it's just something on my computer then . . . |
Success on x86_64-linux (full log) Attempted: texlive.bin Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: texlive.bin Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: texlive.bin Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: texlive.bin Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: texlive.bin Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: texlive.bin Partial log (click to expand)
|
A package has already been updated:
|
@dotlambda the last commit puts my private snapshot mirror first on the URL list, so this should work now. But we still need a good solution for a stable mirror of the package sources... |
But let's see if |
Success on x86_64-linux (full log) Attempted: texlive.bin.core Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: texlive.bin.core Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: texlive.bin.core Partial log (click to expand)
|
Suggested commit: dtzWill@f05ce5d Otherwise our fmtutil invocation doesn't do anything (compare to TL2017 behavior on NixOS).
I saw this as well, but when I went to debug it with some prints/changes it went away and now I can't reproduce :(. |
@timokau I am currently checking this patch with both texlive 2017 and 2018. If it works for both it could go into master. |
Rebased on staging. |
Success on x86_64-darwin (full log) Attempted: texlive.bin.core Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: texlive.bin.core Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: texlive.bin.core Partial log (click to expand)
|
I think this can be merged now. Thanks everyone for your help. |
One of the first two commits (
I can't tell which one because texlive doesn't build with only the first one. |
Great, sorry for the noise. Just noticed the build failing on 18.09 but I see you already cherry-picked it to staging-18.09 too. |
Motivation for this change
Get Texlive 2018 out before the end of 2018, and hopefully into 18.09. Close #40232.
Temporarily based on master for easier building and testing. Will rebase on staging when ready.
Current status
texlive.bin
builds locally on x64_64-linuxtexlive.combined.scheme-full
buildspdflatex
/lualatex
tested with some beamer slides and documents, ok so farcc @bhipple @vcunat @veprbl