texlive-bin: disable mfluajit on ppc64(le) #45475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
10.rebuild-darwin: 0
xeji
reviewed
Aug 22, 2018
| "dvisvgm" "dvipng" # ghostscript dependency | ||
| "luatex" "luajittex" "mp" "pmp" "upmp" "mf" # cairo would bring in X and more | ||
| "xetex" "bibtexu" "bibtex8" "bibtex-x" "upmendex" # ICU isn't small | ||
| ] | ||
| ] ++ (if stdenv.hostPlatform.isPower && stdenv.hostPlatform.is64bit then [ "mfluajit" ] else [])) |
There was a problem hiding this comment.
Instead of if .. then .. else it is better to use
stdenv.lib.optional (stdenv.hostPlatform.isPower && stdenv.hostPlatform.is64bit) "mfluajit",
which does the same thing.
LuaJIT currently has no 64-bit Power support and so breaks the build on such platforms.
CrystalGamma
force-pushed
the
texlive_3
branch
from
df952d0
to
8c73d2b
Compare
|
I think I've seen this support for LuaJIT, either in official commits past the last release, or in some fork. In any case, I don't expect LuaJIT to be among your priorities right now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
LuaJIT currently has no 64-bit Power support and so breaks the build on such platforms.
Part of my roadmap to bring NixOS to OpenPower platforms.
(If mfluajit should be disabled for all platforms instead of just ppc64(le) for consistency, I wouldn't mind either …)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)