-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openjdk10: add darwin support #45575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@GrahamcOfBorg bulid openjdk10 |
@GrahamcOfBorg build openjdk10 |
Success on x86_64-darwin (full log) Attempted: openjdk10 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: openjdk10 Partial log (click to expand)
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: openjdk10 Partial log (click to expand)
|
Thank you! :) |
Motivation for this change
Copied from the jdk8 derivation and adjusted for jdk10: https://github.com/NixOS/nixpkgs/blob/beaa0984c63f6e93a9ddfae18c70d39602e90cca/pkgs/development/compilers/openjdk/darwin/8.nix.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)