Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitea: Symlink gitea locales to match running gitea version #45608

Merged
merged 1 commit into from
Aug 25, 2018
Merged

nixos/gitea: Symlink gitea locales to match running gitea version #45608

merged 1 commit into from
Aug 25, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Aug 24, 2018 •
edited
Loading

Motivation for this change

This prevents issues when gitea adds new locales etc. And if they
change locale values in future versions. Or if you rollback to a
previous version of gitea it might be a good idea to use the previous
locale files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @disassembler

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Aug 24, 2018
infinisil
infinisil approved these changes Aug 24, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@etu etu force-pushed the fix-gitea-locale-updates branch 2 times, most recently from 6094c6b to 3aad82e Compare August 25, 2018 07:16
@etu etu changed the title nixos/gitea: Always copy gitea locales to match running gitea version nixos/gitea: Symlink gitea locales to match running gitea version Aug 25, 2018
@etu
nixos/gitea: Symlink gitea locales to match running gitea version
a098cc9 
This prevents issues when gitea adds new locales etc. And if they
change locale values in future versions. Or if you rollback to a
previous version of gitea it might be a good idea to use the previous
locale files.
@adisbladis adisbladis merged commit dff43f1 into NixOS:master Aug 25, 2018
@etu etu deleted the fix-gitea-locale-updates branch August 25, 2018 07:27
@xeji xeji mentioned this pull request Aug 29, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@etu @infinisil @adisbladis @GrahamcOfBorg