coreutils: split a coreutils-full version #45720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tool --version` now gets additional line: Packaged by https://NixOS.org
- default coreutils is stripped of /share/ (11 -> 2 MiB) - coreutils-full retains /share/ and adds openssl for faster *sum tools - NixOS systemPackages contains coreutils-full - *Support parameter defaults are moved inside (it seemed confusing to have `? false` and "at once" with `? isLinux`) Closure considerations: + typical build-time closure will get lighter by ~9 MiB - typical closure of NixOS installation will grow by ~2 MiB, due to referring to both versions. I think it would be possible to re-use most of the utils between the two versions, but the expression would get much more complex. I considered having stdenv with minimal coreutils and the default `coreutils` attribute being full, but it turned out there were too many trivial references in nixpkgs, so it didn't seem easy to keep rebuild impact of openssl from growing significantly.
|
I chose a generic name |
GrahamcOfBorg
added
6.topic: nixos
Mic92
reviewed
Aug 28, 2018
| }; | ||
|
|
||
| coreutils = callPackage ../tools/misc/coreutils { }; | ||
| coreutils-full = coreutils.override { minimal = false; }; |
There was a problem hiding this comment.
Would be coreutils-full be part of NixOS?
There was a problem hiding this comment.
Yes, see the nixos/* part of the diff: https://github.com/NixOS/nixpkgs/pull/45720/files#diff-dcba170e079cd72958889058d01a4a02R16 ;-)
GrahamcOfBorg
added
10.rebuild-darwin-stdenv
|
Success on aarch64-linux (full log) Attempted: coreutils Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: coreutils Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: coreutils Partial log (click to expand)
|
|
Are dashes in attributes the official convention now? I think the manual still mentions not to do that. |
|
Failure on aarch64-linux (full log) Attempted: pkgsCross.scaleway-c1.coreutils-full, pkgsCross.armv7l-hf-multiplatform.coreutils-full Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: pkgsCross.scaleway-c1.coreutils-full, pkgsCross.armv7l-hf-multiplatform.coreutils-full Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Have faster
*sumutilities. Details in commits and previous discussion threads: #44937 Please comment what you think.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)