Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcolor3: 2.2 → 2.3 #45949

Merged
merged 1 commit into from
Sep 2, 2018
Merged

gcolor3: 2.2 → 2.3 #45949

merged 1 commit into from
Sep 2, 2018

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Sep 2, 2018

Motivation for this change

https://www.hjdskes.nl/blog/gcolor3-2.3/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gcolor3

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/xw7486sag4qkb01v9bqw1yd3yl1ws0wz-gcolor3-2.3/bin/gcolor3
shrinking RPATHs of ELF executables and libraries in /nix/store/xw7486sag4qkb01v9bqw1yd3yl1ws0wz-gcolor3-2.3
shrinking /nix/store/xw7486sag4qkb01v9bqw1yd3yl1ws0wz-gcolor3-2.3/bin/.gcolor3-wrapped
gzipping man pages under /nix/store/xw7486sag4qkb01v9bqw1yd3yl1ws0wz-gcolor3-2.3/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xw7486sag4qkb01v9bqw1yd3yl1ws0wz-gcolor3-2.3/bin
patching script interpreter paths in /nix/store/xw7486sag4qkb01v9bqw1yd3yl1ws0wz-gcolor3-2.3
checking for references to /build in /nix/store/xw7486sag4qkb01v9bqw1yd3yl1ws0wz-gcolor3-2.3...
/nix/store/xw7486sag4qkb01v9bqw1yd3yl1ws0wz-gcolor3-2.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gcolor3

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3/bin/gcolor3
shrinking RPATHs of ELF executables and libraries in /nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3
shrinking /nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3/bin/.gcolor3-wrapped
gzipping man pages under /nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3/bin
patching script interpreter paths in /nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3
checking for references to /build in /nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3...
/nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gcolor3

Partial log (click to expand)

/nix/store/xw7486sag4qkb01v9bqw1yd3yl1ws0wz-gcolor3-2.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gcolor3

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3/bin/gcolor3
shrinking RPATHs of ELF executables and libraries in /nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3
shrinking /nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3/bin/.gcolor3-wrapped
gzipping man pages under /nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3/bin
patching script interpreter paths in /nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3
checking for references to /build in /nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3...
/nix/store/amr0f0j03q06v6w7i2wsrnhaandiyizj-gcolor3-2.3

@xeji
Copy link
Contributor

xeji commented Sep 2, 2018

works and looks nice 👍

@jtojnar
Copy link
Member Author

jtojnar commented Sep 2, 2018

Still waiting for Darwin build.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: gcolor3

Partial log (click to expand)

[11/18] Compiling C object 'src/src@@gcolor3@exe/gcolor3-color-row.c.o'.
FAILED: src/src@@gcolor3@exe/gcolor3-color-row.c.o
/nix/store/2gdwhdzhy4iwkp7fh8v6gy6nxj1zi9pv-clang-wrapper-5.0.2/bin/cc -Isrc/src@@gcolor3@exe -Isrc -I../src -Isrc/../data -I../src/../data -Isrc/.. -I../src/.. -I/nix/store/iqhfysn7yldnpii012ni8fs788pz8fcb-gtk+3-3.22.30-dev/include/gtk-3.0 -I/nix/store/14ji0qzxppxbx24w2dccglpjvwchy60c-glib-2.56.0-dev/include/glib-2.0 -I/nix/store/bysph12diipmacijqkm76fg869n740dg-glib-2.56.0/lib/glib-2.0/include -I/nix/store/fcs8183pyn7akshb1ykn91wxmqh412x0-cairo-1.15.12-dev/include/cairo -I/nix/store/ys684rkpv2kiwldp63bxk4jyrwyk76g2-freetype-2.9-dev/include/freetype2 -I/nix/store/ys684rkpv2kiwldp63bxk4jyrwyk76g2-freetype-2.9-dev/include -I/nix/store/nfb968h86nsrb8sc956wrbbb2zfqk587-pango-1.42.1-dev/include/pango-1.0 -I/nix/store/69xz4v3nhbwqgr4nwfhmxmxl35qb3yc6-fribidi-1.0.5/include/fribidi -I/nix/store/11z8y89k6lx6rd4jwzyzs2s1siy9bgrr-gdk-pixbuf-2.36.12-dev/include/gdk-pixbuf-2.0 -I/nix/store/ylp1i2zchllfhkb7nyaw3mqwsd8rs057-atk-2.28.1-dev/include/atk-1.0 -Xclang -fcolor-diagnostics -pipe -Wall -Winvalid-pch -Werror -std=c99 -O3  -MD -MQ 'src/src@@gcolor3@exe/gcolor3-color-row.c.o' -MF 'src/src@@gcolor3@exe/gcolor3-color-row.c.o.d' -o 'src/src@@gcolor3@exe/gcolor3-color-row.c.o' -c ../src/gcolor3-color-row.c
../src/gcolor3-color-row.c:88:6: error: implicit conversion from enumeration type 'GtkStateType' to different enumeration type 'GtkStateFlags' [-Werror,-Wenum-conversion]
                                        GTK_STATE_NORMAL,
                                        ^~~~~~~~~~~~~~~~
1 error generated.
ninja: build stopped: subcommand failed.
builder for '/nix/store/02xin3673apfn0n4089im8aph3zisylg-gcolor3-2.3.drv' failed with exit code 1
error: build of '/nix/store/02xin3673apfn0n4089im8aph3zisylg-gcolor3-2.3.drv' failed

@jtojnar jtojnar force-pushed the gcolor3 branch 2 times, most recently from 8fcc15d to 3d57fe6 Compare September 2, 2018 16:36
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gcolor3

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/c63zh27xnxjzqyp6pa6iaqgnr28cli4l-gcolor3-2.3/bin/gcolor3
shrinking RPATHs of ELF executables and libraries in /nix/store/c63zh27xnxjzqyp6pa6iaqgnr28cli4l-gcolor3-2.3
shrinking /nix/store/c63zh27xnxjzqyp6pa6iaqgnr28cli4l-gcolor3-2.3/bin/.gcolor3-wrapped
gzipping man pages under /nix/store/c63zh27xnxjzqyp6pa6iaqgnr28cli4l-gcolor3-2.3/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c63zh27xnxjzqyp6pa6iaqgnr28cli4l-gcolor3-2.3/bin
patching script interpreter paths in /nix/store/c63zh27xnxjzqyp6pa6iaqgnr28cli4l-gcolor3-2.3
checking for references to /build in /nix/store/c63zh27xnxjzqyp6pa6iaqgnr28cli4l-gcolor3-2.3...
/nix/store/c63zh27xnxjzqyp6pa6iaqgnr28cli4l-gcolor3-2.3

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: gcolor3

Partial log (click to expand)

[12/18] Compiling C object 'src/src@@gcolor3@exe/gcolor3-color-selection.c.o'.
FAILED: src/src@@gcolor3@exe/gcolor3-color-selection.c.o
/nix/store/2gdwhdzhy4iwkp7fh8v6gy6nxj1zi9pv-clang-wrapper-5.0.2/bin/cc -Isrc/src@@gcolor3@exe -Isrc -I../src -Isrc/../data -I../src/../data -Isrc/.. -I../src/.. -I/nix/store/iqhfysn7yldnpii012ni8fs788pz8fcb-gtk+3-3.22.30-dev/include/gtk-3.0 -I/nix/store/14ji0qzxppxbx24w2dccglpjvwchy60c-glib-2.56.0-dev/include/glib-2.0 -I/nix/store/bysph12diipmacijqkm76fg869n740dg-glib-2.56.0/lib/glib-2.0/include -I/nix/store/fcs8183pyn7akshb1ykn91wxmqh412x0-cairo-1.15.12-dev/include/cairo -I/nix/store/ys684rkpv2kiwldp63bxk4jyrwyk76g2-freetype-2.9-dev/include/freetype2 -I/nix/store/ys684rkpv2kiwldp63bxk4jyrwyk76g2-freetype-2.9-dev/include -I/nix/store/nfb968h86nsrb8sc956wrbbb2zfqk587-pango-1.42.1-dev/include/pango-1.0 -I/nix/store/69xz4v3nhbwqgr4nwfhmxmxl35qb3yc6-fribidi-1.0.5/include/fribidi -I/nix/store/11z8y89k6lx6rd4jwzyzs2s1siy9bgrr-gdk-pixbuf-2.36.12-dev/include/gdk-pixbuf-2.0 -I/nix/store/ylp1i2zchllfhkb7nyaw3mqwsd8rs057-atk-2.28.1-dev/include/atk-1.0 -Xclang -fcolor-diagnostics -pipe -Wall -Winvalid-pch -Werror -std=c99 -O3  -MD -MQ 'src/src@@gcolor3@exe/gcolor3-color-selection.c.o' -MF 'src/src@@gcolor3@exe/gcolor3-color-selection.c.o.d' -o 'src/src@@gcolor3@exe/gcolor3-color-selection.c.o' -c ../src/gcolor3-color-selection.c
../src/gcolor3-color-selection.c:39:10: fatal error: 'gdk/gdkwayland.h' file not found
#include <gdk/gdkwayland.h>
         ^~~~~~~~~~~~~~~~~~
1 error generated.
ninja: build stopped: subcommand failed.
builder for '/nix/store/3y4v4cfpfbwpscy81hpxkjyj5fifb94m-gcolor3-2.3.drv' failed with exit code 1
error: build of '/nix/store/3y4v4cfpfbwpscy81hpxkjyj5fifb94m-gcolor3-2.3.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gcolor3

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/r29lhc0apz7hcjgkwnsy53zjvxb320dx-gcolor3-2.3/bin/gcolor3
shrinking RPATHs of ELF executables and libraries in /nix/store/r29lhc0apz7hcjgkwnsy53zjvxb320dx-gcolor3-2.3
shrinking /nix/store/r29lhc0apz7hcjgkwnsy53zjvxb320dx-gcolor3-2.3/bin/.gcolor3-wrapped
gzipping man pages under /nix/store/r29lhc0apz7hcjgkwnsy53zjvxb320dx-gcolor3-2.3/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r29lhc0apz7hcjgkwnsy53zjvxb320dx-gcolor3-2.3/bin
patching script interpreter paths in /nix/store/r29lhc0apz7hcjgkwnsy53zjvxb320dx-gcolor3-2.3
checking for references to /build in /nix/store/r29lhc0apz7hcjgkwnsy53zjvxb320dx-gcolor3-2.3...
/nix/store/r29lhc0apz7hcjgkwnsy53zjvxb320dx-gcolor3-2.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gcolor3

Partial log (click to expand)

Running custom install script '/private/tmp/nix-build-gcolor3-2.3.drv-0/source/meson_install.sh share'
glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
Wrapping program /nix/store/ncd5lcrc8wyri4502cfxc526hc61am4h-gcolor3-2.3/bin/gcolor3
gzipping man pages under /nix/store/ncd5lcrc8wyri4502cfxc526hc61am4h-gcolor3-2.3/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ncd5lcrc8wyri4502cfxc526hc61am4h-gcolor3-2.3/bin
patching script interpreter paths in /nix/store/ncd5lcrc8wyri4502cfxc526hc61am4h-gcolor3-2.3
/nix/store/ncd5lcrc8wyri4502cfxc526hc61am4h-gcolor3-2.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gcolor3

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/zh82sb965i8hwsakws4mnqi27qcgc088-gcolor3-2.3/bin/gcolor3
shrinking RPATHs of ELF executables and libraries in /nix/store/zh82sb965i8hwsakws4mnqi27qcgc088-gcolor3-2.3
shrinking /nix/store/zh82sb965i8hwsakws4mnqi27qcgc088-gcolor3-2.3/bin/.gcolor3-wrapped
gzipping man pages under /nix/store/zh82sb965i8hwsakws4mnqi27qcgc088-gcolor3-2.3/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zh82sb965i8hwsakws4mnqi27qcgc088-gcolor3-2.3/bin
patching script interpreter paths in /nix/store/zh82sb965i8hwsakws4mnqi27qcgc088-gcolor3-2.3
checking for references to /build in /nix/store/zh82sb965i8hwsakws4mnqi27qcgc088-gcolor3-2.3...
/nix/store/zh82sb965i8hwsakws4mnqi27qcgc088-gcolor3-2.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gcolor3

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/5zawg2lynafxvgxi04fh77b3m2qnzwlb-gcolor3-2.3/bin/gcolor3
shrinking RPATHs of ELF executables and libraries in /nix/store/5zawg2lynafxvgxi04fh77b3m2qnzwlb-gcolor3-2.3
shrinking /nix/store/5zawg2lynafxvgxi04fh77b3m2qnzwlb-gcolor3-2.3/bin/.gcolor3-wrapped
gzipping man pages under /nix/store/5zawg2lynafxvgxi04fh77b3m2qnzwlb-gcolor3-2.3/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5zawg2lynafxvgxi04fh77b3m2qnzwlb-gcolor3-2.3/bin
patching script interpreter paths in /nix/store/5zawg2lynafxvgxi04fh77b3m2qnzwlb-gcolor3-2.3
checking for references to /build in /nix/store/5zawg2lynafxvgxi04fh77b3m2qnzwlb-gcolor3-2.3...
/nix/store/5zawg2lynafxvgxi04fh77b3m2qnzwlb-gcolor3-2.3

@jtojnar jtojnar merged commit e2a731f into NixOS:master Sep 2, 2018
@jtojnar jtojnar deleted the gcolor3 branch September 2, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants