-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.phonopy: refactor #46161
Conversation
@GrahamcOfBorg build python2.pkgs.phonopy python3.pkgs.phonopy |
Failure on x86_64-linux (full log) Attempted: python2.pkgs.phonopy, python3.pkgs.phonopy Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: python2.pkgs.phonopy, python3.pkgs.phonopy Partial log (click to expand)
|
That is a weird test failure on x86_64-linux. I cannot reproduce and I am using sandbox... |
Likely the tolerances are incorrect. You can disable the specific test. |
Fixing phonopy not building. Tests were moved on Jul 30.
b5a7c16
to
6cbc581
Compare
@FRidh I have removed that test and added a comment about the issue. Test on x86 should pass now |
@GrahamcOfBorg build python2.pkgs.phonopy python3.pkgs.phonopy |
Success on x86_64-linux (full log) Attempted: python2.pkgs.phonopy, python3.pkgs.phonopy Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: python2.pkgs.phonopy, python3.pkgs.phonopy Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: python2.pkgs.phonopy, python3.pkgs.phonopy Partial log (click to expand)
|
Fixing phonopy not building. Tests were moved on Jul 30. (cherry picked from commit 6586765)
backported: 53b9062 |
Fixing phonopy not building. Tests were moved on Jul 30.
Motivation for this change
Fixing #45960 phonopy not building.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)