-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
earlyoom: fix version number #46481
earlyoom: fix version number #46481
Conversation
earlyoom's Makefile attempts to detect the current version using git, but we don't keep .git in its source, so this fails. We can however set the VERSION environment variable to override this, as we now do.
@GrahamcOfBorg build earlyoom |
Success on x86_64-linux (full log) Attempted: earlyoom Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: earlyoom Partial log (click to expand)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: earlyoom Partial log (click to expand)
|
earlyoom's Makefile attempts to detect the current version using git, but we don't keep .git in its source, so this fails. We can however set the VERSION environment variable to override this, as we now do. (cherry picked from commit ac679e7)
[detached HEAD 12703a0] earlyoom: fix version number (#46481) |
version = "0.11"; | ||
name = "earlyoom-${VERSION}"; | ||
# This environment variable is read by make to set the build version. | ||
VERSION = "0.11"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a new release, the ryantm bot might pick it up eventually now that rev
is also set properly.
Failure on x86_64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: earlyoom Partial log (click to expand)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: earlyoom Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: earlyoom Partial log (click to expand)
|
Motivation for this change
Before:
After:
earlyoom's Makefile attempts to detect the current version using git,
but we don't keep .git in its source, so this fails. We can however
set the VERSION environment variable to override this, as we now do.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after): no change