twa: init at 1.3.1

[Avaq]

Motivation for this change

More and more of my colleagues are making the switch to NixOS, and it would be convenient for them, and myself, if we could install twa (a tool we use) directly from nixpkgs.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Fits CONTRIBUTING.md.

[Avaq]

This is the first ever package I've defined with Nix. There are a few questions left unanswered for me:

1. I wasn't sure where to put this sort of thing. I found the following candidates (ordered by my view on fitness):

   • tools/networking/twa
   • tools/security/twa
   • development/web/twa
   • development/tools/twa

2. I've added myself as a maintainer. I'm not fully aware what that implies, and whether it was the right thing to do.

[Avaq]

I think this could just be version, rather than with the interpolation. I copied this from another package definition, though, so I left it in case it's convention.

[Mic92]

yes, rev = version; is preferred here.

[Mic92]

This needs to be wrapped with makeWrapper to have curl, netcat and ncurses in its PATH:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/phantomjs2/default.nix#L91

[Avaq]

needs to be wrapped with makeWrapper to have curl, netcat and ncurses in its PATH -- @Mic92

Done. This time I tested with nix-shell --pure and found it working.

However, I also realized that the tscore command being installed runs with awk as the interpreter. Is it normal that this (and bash for twa) are kind of implicit run-time dependencies?

[Mic92]

Tscore has awk in its shebang, no?

[Avaq]

Tscore has awk in its shebang, no?

Yes. It does. Does that mean Nix is aware of the dependency to awk?

[Mic92]

Yes. It automatically scans runtime dependencies by looking for nix store paths in the package.

[Mic92]

2. I've added myself as a maintainer. I'm not fully aware what that implies, and whether it was the right thing to do.

This is the right thing and we want that for all new packages. https://nixos.wiki/wiki/Nixpkgs#Becoming_a_Nixpkgs_maintainer

[Avaq]

I'm resolving the conflict. I also might use a different email address.