Add roccat-tools and libgaminggear dependency #47493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
10.rebuild-darwin: 0
|
Failure on x86_64-darwin (full log) Attempted: libgaminggear The following builds were skipped because they don't evaluate on x86_64-darwin: roccat-tools Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libgaminggear, roccat-tools Partial log (click to expand)
|
This is a requirement for roccat-tools, which is going to be introduced soon. The reason why I'm using propagatedBuildInputs here is because the pkg-config file lists *all* of the dependencies in Requires and Requires.private, so those libraries are needed whenever any software uses that library. Signed-off-by: aszlig <aszlig@nix.build>
I had this package along with libgaminggear laying around since June 2016[1] and basically just did the setup for the ROCCAT device once and never touched it again since then. However, I got requests from other users who might need this, so I decided to finally upstream it along with using the latest versions. There were a few hardcoded paths to fix, like eg. /etc/xdg and another one that used /var/lib/roccat, the latter I moved into $XDG_DATA_HOME instead. The reason why I put it in os-specific/linux is that the official site explicitly states that it's for Linux only and I specified the platforms attribute accordingly. [1]: https://gist.github.com/aszlig/3a01c0c23254a68c2be4c6df59e26862 Signed-off-by: aszlig <aszlig@nix.build> Cc: @devhell
|
Success on aarch64-linux (full log) Attempted: libgaminggear, roccat-tools Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: libgaminggear, roccat-tools Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libgaminggear, roccat-tools Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: libgaminggear, roccat-tools Partial log (click to expand)
|
aszlig
added a commit
that referenced
this pull request
Sep 28, 2018
This adds roccat-tools and one required dependency (libgaminggear), which I had laying around since June 2016 but never submitted upstream until now. The tools are required if you want to configure one of the hardware devices from the manufactorer ROCCAT. Builds for both have been tested against i686-linux, x86_64-linux and aarch64-linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this package along with
libgaminggearlaying around since June 2016 and basically just did the setup for the ROCCAT device once and never touched it again since then. However, I got requests from other users who might need this, so I decided to finally upstream it along with using the latest versions.The change here should be non-controversal and it's mainly here to check with ofborg for possible other platforms that
libgaminggearmight work on, because I only have access to x86 machines at the moment.