Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitkraken: 4.0.2 -> 4.0.5 #47512

Merged
merged 1 commit into from
Sep 29, 2018
Merged

gitkraken: 4.0.2 -> 4.0.5 #47512

merged 1 commit into from
Sep 29, 2018

Conversation

KiaraGrouwstra
Copy link
Contributor

@KiaraGrouwstra KiaraGrouwstra commented Sep 29, 2018 •
edited
Loading

Motivation for this change

Fixes #47498. Note that the releases have moved to a new URL; I'm not sure they still host the earlier versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@KiaraGrouwstra
gitkraken: 4.0.2 -> 4.0.5
ac900d2 
Fixes NixOS#47498. Note that the releases have moved to a new URL; I'm not sure they still host the earlier versions.
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Sep 29, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 29, 2018

Does it only segfault for me?

$ nix-shell -p gitkraken
[nix-shell:~/git/nixpkgs]$ gitkraken
Segmentation fault (core dumped)

@xeji
Copy link
Contributor

xeji commented Sep 29, 2018

Works here.

@Mic92
Copy link
Member

Mic92 commented Sep 29, 2018

Should be ok then I guess.

@xeji xeji merged commit 9d727e0 into NixOS:master Sep 29, 2018
xeji pushed a commit that referenced this pull request Sep 29, 2018
@KiaraGrouwstra @xeji
gitkraken: 4.0.2 -> 4.0.5 (#47512)
1d5b7a7 
Fixes #47498. Note that the releases have moved to a new URL; I'm not sure they still host the earlier versions.

(cherry picked from commit 9d727e0)

backported because previous source url returns 404.
@xeji
Copy link
Contributor

xeji commented Sep 29, 2018

backported to 18.09 because previous source url returns 404: 1d5b7a7

@KiaraGrouwstra KiaraGrouwstra deleted the patch-1 branch September 30, 2018 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KiaraGrouwstra @Mic92 @xeji @GrahamcOfBorg