-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Monero for upcoming hard fork #48301
Conversation
Failure on aarch64-linux (full log) Attempted: monero, xmr-stak Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: monero The following builds were skipped because they don't evaluate on x86_64-darwin: xmr-stak Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: monero, xmr-stak Partial log (click to expand)
|
@GrahamcOfBorg build monero-gui |
Failure on aarch64-linux (full log) Attempted: monero-gui Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: monero-gui Partial log (click to expand)
|
I think monero-gui also needs an update. It built before. |
Timed out, unknown build status on x86_64-darwin (full log) Attempted: monero-gui Partial log (click to expand)
|
There hasn't been a new release of monero-gui yet. I'll check if packaging a commit from master makes sense. |
This happens everytime there is a hard fork: the gui needs monero core to build so it breaks when the daemon is updated. |
The GUI has been updated! |
@GrahamcOfBorg build monero-gui |
Success on aarch64-linux (full log) Attempted: monero-gui Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: monero, monero-gui, xmr-stak Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: monero, monero-gui, xmr-stak Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: monero, monero-gui The following builds were skipped because they don't evaluate on x86_64-darwin: xmr-stak Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: monero-gui Partial log (click to expand)
|
monero-gui didn't previously build on Darwin so no regression. Since the nix log output makes it hard to know for monero: @GrahamcOfBorg build monero |
Success on x86_64-linux (full log) Attempted: monero Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: monero Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: monero Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be of interest to remove darwin and aarch64 from the non-building platforms, but that's not the point of this PR.
Success on x86_64-linux (full log) Attempted: monero-gui Partial log (click to expand)
|
Ugh... tried to backport and it looks like something broke; this is on current master:
Either: the hash wasn't right in this PR (but then what did ofborg build?) or upstream moved the tag (uuuuuuuuggghhhhhh). @rnhmjoj any ideas which of the two happened? Is the new hash expected? Did something happen to monero-gui (and would you know? are you following that project?) (oh, and all negative feelings are towards the situation, not towards the people here.) |
It really has changed: not sure what happened here. They released a new versione anyway so l'll update it. |
Touching a tag makes me sad :/. cc me in the new PR, I'll backport with the update. Thanks! |
Update Monero for upcoming hard fork (backports #48301)
Motivation for this change
Fix #48294
Things done
This should also be backported to stable.