-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epson-workforce-635-nx625-series: init at 1.0.1 #48752
epson-workforce-635-nx625-series: init at 1.0.1 #48752
Conversation
variables `maintainers` and `licenses` were invisible, leading to build errors; fixed this.
From GrahamcOfBorg-eval log:
I have no idea what to do about this. |
name = "epson-inkjet-printer-workforce-635-nx625-series"; | ||
version = "1.0.1"; | ||
|
||
src = builtins.fetchurl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use fetchurl
instead of builtins.fetchurl
to avoid the evaluation warning.
builtins.fetchurl (was used) cannot access uris not in `allowed-uris` when built in restricted mode (like ofborg does)
@GrahamcOfBorg build epson-workforce-635-nx625-series |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: epson-workforce-635-nx625-series Partial log (click to expand)
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: epson-workforce-635-nx625-series Partial log (click to expand)
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: epson-workforce-635-nx625-series Partial log (click to expand)
|
}; | ||
''; | ||
downloadPage = https://download.ebz.epson.net/dsc/du/02/DriverDownloadInfo.do?LG2=EN&CN2=&DSCMI=16857&DSCCHK=4334d3487503d7f916ccf5d58071b05b7687294f; | ||
license = with lib.licenses; [ lgpl21 epson ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the whole source code is dual-licensed, dropping epson is better because it can be built on hydra then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package includes lgpl source code and proprietary object files which are (dynamically) linked against. Since the proprietary and lgpl parts are distributed in one rpm I don't think one may leave out the epson license even if splitting the package into two subpackages in nixpkgs.
@Mic92 Is there any problem why this doesn't get merged? After all, this is without any comments or failed tests since Oct 22. |
@jorsn Thanks for the update. This pull request simply went under. |
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)nix path-info -S nixpkgs.epson-workforce-635-nx625-series
or what? Before and after what?More
Tested with my Epson Stylus Office BX525WD wireless inkjet printer with success.