tmux: fix tmux sha256 hash #49327

ookhoi · 2018-10-28T09:59:15Z

Motivation for this change

fix:

unpacking source archive /build/2.8.tar.gz
fixed-output derivation produced path '/nix/store/5ffizfra8bqflflbi985d6y427ndq8a9-source' with sha256 hash '1fy87wvxn7r7jzqapvjisc1iizic3kxqk2lv83giqmw1y4g3s7rl' instead of the expected hash '0n8sjddy00xgh1rvvw968hh72pyslg1gahmzajfc4b3xax87drpi'
repairing outputs of '/nix/store/9h7m55sxcn1ah8fxynkfzk0gxhv31yl6-synctex-missing-header.patch.drv'...
cannot build derivation '/nix/store/inbx3y8s5ni778smbbzszhwpx5jq44jk-tmux-2.8.drv': 1 dependencies couldn't be built
repairing outputs of '/nix/store/0g3ab8b617jcl0qw7xympfnwz2a29rlv-token_store-0.1.2.tar.gz.drv'...
repairing outputs of '/nix/store/yq9kh0w74chi9w8rz97ff9wsd6iy82g9-sysfsutils-2.1.0.tar.gz.drv'...
repairing outputs of '/nix/store/gli61d3b5hykmzii2xsmav2wsj31kr71-system-generators.drv'...
cannot build derivation '/nix/store/3g0iz00kxpb46p96akiagzy5c5851d74-system-path.drv': 1 dependencies couldn't be built
repairing outputs of '/nix/store/d1f7gjdm5axz0ai1ia4f6jg0w9prn9pb-tcl8.6.6-src.tar.gz.drv'...
repairing outputs of '/nix/store/4qgyaa4c2qm599xylak4ms7704ml5ja0-thin-provisioning-tools-0.7.6.drv'...
cannot build derivation '/nix/store/s21w2jrs9p5wl2xijz494c5skzr40rxk-nixos-system-p70-19.03pre157041.64553463956.drv': 1 dependencies couldn't be built
error: build of '/nix/store/s21w2jrs9p5wl2xijz494c5skzr40rxk-nixos-system-p70-19.03pre157041.64553463956.drv' failed

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

andir · 2018-10-28T10:08:26Z

@GrahamcOfBorg build tmux

GrahamcOfBorg · 2018-10-28T10:09:09Z

Success on x86_64-linux (full log)

Attempted: tmux

Partial log (click to expand)

strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0v4kkfzsmd8p9vmm40nf5y0a4mcdihkb-tmux-2.8/bin
patching script interpreter paths in /nix/store/0v4kkfzsmd8p9vmm40nf5y0a4mcdihkb-tmux-2.8
checking for references to /build in /nix/store/0v4kkfzsmd8p9vmm40nf5y0a4mcdihkb-tmux-2.8...
shrinking RPATHs of ELF executables and libraries in /nix/store/z5bgn2kwk7s816dbyxv34x1lk2cf6nyl-tmux-2.8-man
gzipping man pages under /nix/store/z5bgn2kwk7s816dbyxv34x1lk2cf6nyl-tmux-2.8-man/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/z5bgn2kwk7s816dbyxv34x1lk2cf6nyl-tmux-2.8-man
checking for references to /build in /nix/store/z5bgn2kwk7s816dbyxv34x1lk2cf6nyl-tmux-2.8-man...
/nix/store/0v4kkfzsmd8p9vmm40nf5y0a4mcdihkb-tmux-2.8

GrahamcOfBorg · 2018-10-28T10:09:23Z

Success on x86_64-darwin (full log)

Attempted: tmux

Partial log (click to expand)

make[1]: Leaving directory '/private/tmp/nix-build-tmux-2.8.drv-0/source'
'/nix/store/xa9rn05f39zmsv5qqz1akyq186y1y7bn-source/completions/tmux' -> '/nix/store/a0ndkabrbwwwgfgncxxjx9gm6sidyfpp-tmux-2.8/share/bash-completion/completions/tmux'
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/a0ndkabrbwwwgfgncxxjx9gm6sidyfpp-tmux-2.8/bin
patching script interpreter paths in /nix/store/a0ndkabrbwwwgfgncxxjx9gm6sidyfpp-tmux-2.8
gzipping man pages under /nix/store/jzdbg3wbcyrrfqng9ghwd2wg3x77cgv6-tmux-2.8-man/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/jzdbg3wbcyrrfqng9ghwd2wg3x77cgv6-tmux-2.8-man
/nix/store/a0ndkabrbwwwgfgncxxjx9gm6sidyfpp-tmux-2.8

andir · 2018-10-28T10:10:15Z

@ookhoi can you adjust the commit message to fit the format described in CONTRIBUTING.MD ?

I am a bit inclined to say we should switch to the got revision instead of tags.. They seem to not honor the concept of release tags.. Or github changed something there...

vcunat · 2018-10-28T10:10:46Z

Uh, did they move tags again? a6dc11e That seems a bad practice. For this expression we could use hashes instead of tag names to specify the revision to download, but that would be relatively ugly.

GrahamcOfBorg · 2018-10-28T10:11:32Z

Success on aarch64-linux (full log)

Attempted: tmux

Partial log (click to expand)

strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p0mm0mnbihqrpvhfryvqwgnkrbh4ry2v-tmux-2.8/bin
patching script interpreter paths in /nix/store/p0mm0mnbihqrpvhfryvqwgnkrbh4ry2v-tmux-2.8
checking for references to /build in /nix/store/p0mm0mnbihqrpvhfryvqwgnkrbh4ry2v-tmux-2.8...
shrinking RPATHs of ELF executables and libraries in /nix/store/zqry8qlqf4lcgm9sdaaa58gxgk4bx2kw-tmux-2.8-man
gzipping man pages under /nix/store/zqry8qlqf4lcgm9sdaaa58gxgk4bx2kw-tmux-2.8-man/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/zqry8qlqf4lcgm9sdaaa58gxgk4bx2kw-tmux-2.8-man
checking for references to /build in /nix/store/zqry8qlqf4lcgm9sdaaa58gxgk4bx2kw-tmux-2.8-man...
/nix/store/p0mm0mnbihqrpvhfryvqwgnkrbh4ry2v-tmux-2.8

LnL7 · 2018-10-28T10:29:05Z

I don't get any hash mismatches, both on linux and darwin.

$ nix-build -A tmux.src --check
checking outputs of '/nix/store/4glcwlmsrgwjr4lnjvaz9xmgmqc5ajgc-source.drv'...

trying https://github.com/tmux/tmux/archive/2.8.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   114    0   114    0     0    217      0 --:--:-- --:--:-- --:--:--   217
100  622k    0  622k    0     0   364k      0 --:--:--  0:00:01 --:--:-- 1420k
unpacking source archive /build/2.8.tar.gz
/nix/store/ajlv30w3yzqsjsb6rrwrr8v478fgjf30-source

ookhoi · 2018-10-28T10:31:00Z

@ookhoi can you adjust the commit message to fit the format described in CONTRIBUTING.MD ?

Of course, is it correct now?

I am a bit inclined to say we should switch to the got revision instead of tags..

I'm affraid I do not understand but I suspect it will make the tmux fetch more robust. What should I change for that?

ookhoi · 2018-10-28T10:34:55Z

I don't get any hash mismatches, both on linux and darwin.

I'm on https://nixos.org/channels/nixos-unstable-small (not sure if that matters)

c0bw3b · 2018-10-28T10:34:56Z

There was a change 11d ago because configure.ac was still mentioning "2.8-rc"
Bad practice but hopefully this should not happen too often...

vcunat · 2018-10-28T10:35:05Z

--check succeeds for me both on this PR and on master; there's something I'm missing. 🤔 EDIT: now it doesn't succeed on master. I don't know... perhaps I did something wrong?

vcunat · 2018-10-28T10:47:00Z

Here, logs of checking the same fetching derivation, different results within a couple minutes.

checking outputs of '/nix/store/4glcwlmsrgwjr4lnjvaz9xmgmqc5ajgc-source.drv'...

trying https://github.com/tmux/tmux/archive/2.8.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   114    0   114    0     0    223      0 --:--:-- --:--:-- --:--:--   223
100  622k    0  622k    0     0   216k      0 --:--:--  0:00:02 --:--:--  312k
unpacking source archive /build/2.8.tar.gz
/nix/store/ajlv30w3yzqsjsb6rrwrr8v478fgjf30-source

vs.

checking outputs of '/nix/store/4glcwlmsrgwjr4lnjvaz9xmgmqc5ajgc-source.drv'...

trying https://github.com/tmux/tmux/archive/2.8.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   114    0   114    0     0    205      0 --:--:-- --:--:-- --:--:--   204
100  622k    0  622k    0     0   332k      0 --:--:--  0:00:01 --:--:--  855k
unpacking source archive /build/2.8.tar.gz
fixed-output derivation produced path '/nix/store/5ffizfra8bqflflbi985d6y427ndq8a9-source' with sha256 hash '1fy87wvxn7r7jzqapvjisc1iizic3kxqk2lv83giqmw1y4g3s7rl' instead of the expected hash '0n8sjddy00xgh1rvvw968hh72pyslg1gahmzajfc4b3xax87drpi'
error: build of '/nix/store/4glcwlmsrgwjr4lnjvaz9xmgmqc5ajgc-source.drv' failed

….7-2.8

xeji · 2018-10-29T14:58:10Z

Strange that we seem to get different results. On my local linux machine the new hash looks correct:

$ nix-prefetch-url https://github.com/tmux/tmux/archive/2.8.tar.gz --unpack
unpacking...
path is '/nix/store/vffvjc24xxvjywpqmcsns7lfin7wr68q-2.8.tar.gz'
1fy87wvxn7r7jzqapvjisc1iizic3kxqk2lv83giqmw1y4g3s7rl

xeji · 2018-10-29T15:00:44Z

@ookhoi since upstream seems to have moved the tag, let's pin this to the corresponding upstream git commit instead of the version tag to ensure it's stable:

-    rev = version;
+    rev = "01918cb0170e07288d3aec624516e6470bf5b7fc";

ookhoi · 2018-11-03T16:31:29Z

@ookhoi since upstream seems to have moved the tag, let's pin this to the corresponding upstream git commit instead of the version tag to ensure it's stable:
-    rev = version;
+    rev = "01918cb0170e07288d3aec624516e6470bf5b7fc";

Sorry for the delay @xeji
I've replaced version with "01918cb0170e07288d3aec624516e6470bf5b7fc" and am currently building.

ookhoi · 2018-11-04T14:57:24Z

I'm running tmux 2.8 now

xeji · 2018-11-04T17:31:34Z

@GrahamcOfBorg build tmux

GrahamcOfBorg · 2018-11-04T17:31:53Z

Success on x86_64-darwin (full log)

Attempted: tmux

Partial log (click to expand)

/nix/store/a0ndkabrbwwwgfgncxxjx9gm6sidyfpp-tmux-2.8

GrahamcOfBorg · 2018-11-04T17:32:35Z

Success on x86_64-linux (full log)

Attempted: tmux

Partial log (click to expand)

/nix/store/0v4kkfzsmd8p9vmm40nf5y0a4mcdihkb-tmux-2.8

GrahamcOfBorg · 2018-11-04T17:32:47Z

Success on aarch64-linux (full log)

Attempted: tmux

Partial log (click to expand)

strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p0mm0mnbihqrpvhfryvqwgnkrbh4ry2v-tmux-2.8/bin
patching script interpreter paths in /nix/store/p0mm0mnbihqrpvhfryvqwgnkrbh4ry2v-tmux-2.8
checking for references to /build in /nix/store/p0mm0mnbihqrpvhfryvqwgnkrbh4ry2v-tmux-2.8...
shrinking RPATHs of ELF executables and libraries in /nix/store/zqry8qlqf4lcgm9sdaaa58gxgk4bx2kw-tmux-2.8-man
gzipping man pages under /nix/store/zqry8qlqf4lcgm9sdaaa58gxgk4bx2kw-tmux-2.8-man/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/zqry8qlqf4lcgm9sdaaa58gxgk4bx2kw-tmux-2.8-man
checking for references to /build in /nix/store/zqry8qlqf4lcgm9sdaaa58gxgk4bx2kw-tmux-2.8-man...
/nix/store/p0mm0mnbihqrpvhfryvqwgnkrbh4ry2v-tmux-2.8

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 28, 2018

tmux: fix tmux sha256 hash

a7a38fb

ookhoi changed the title ~~tmux-2.7-2.8 - fix tmux sha256 hash~~ tmux: fix tmux sha256 hash Oct 28, 2018

Sander Hollaar added 5 commits October 28, 2018 12:14

Merge branch 'master' of https://github.com/NixOS/nixpkgs into tmux-2…

e8160e7

….7-2.8

Merge branch 'master' of https://github.com/NixOS/nixpkgs into tmux-2…

76663e6

….7-2.8

Merge branch 'master' of https://github.com/NixOS/nixpkgs into tmux-2…

0a78594

….7-2.8

Merge branch 'master' of https://github.com/NixOS/nixpkgs into tmux-2…

8d70ff7

….7-2.8

Merge branch 'master' of https://github.com/NixOS/nixpkgs into tmux-2…

b9dd2e6

….7-2.8

Sander Hollaar added 2 commits November 3, 2018 17:20

pin to upstream commit

12d95d6

pin version to upstream commit

b7d0c4a

xeji merged commit 76f803f into NixOS:master Nov 4, 2018

ookhoi deleted the tmux-2.7-2.8 branch November 4, 2018 18:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tmux: fix tmux sha256 hash #49327

tmux: fix tmux sha256 hash #49327

ookhoi commented Oct 28, 2018 •

edited

Loading

andir commented Oct 28, 2018

GrahamcOfBorg commented Oct 28, 2018

GrahamcOfBorg commented Oct 28, 2018

andir commented Oct 28, 2018

vcunat commented Oct 28, 2018

GrahamcOfBorg commented Oct 28, 2018

LnL7 commented Oct 28, 2018

ookhoi commented Oct 28, 2018

ookhoi commented Oct 28, 2018

c0bw3b commented Oct 28, 2018

vcunat commented Oct 28, 2018 •

edited

Loading

vcunat commented Oct 28, 2018

xeji commented Oct 29, 2018

xeji commented Oct 29, 2018

ookhoi commented Nov 3, 2018

ookhoi commented Nov 4, 2018

xeji commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

tmux: fix tmux sha256 hash #49327

tmux: fix tmux sha256 hash #49327

Conversation

ookhoi commented Oct 28, 2018 • edited Loading

Motivation for this change

Things done

andir commented Oct 28, 2018

GrahamcOfBorg commented Oct 28, 2018

GrahamcOfBorg commented Oct 28, 2018

andir commented Oct 28, 2018

vcunat commented Oct 28, 2018

GrahamcOfBorg commented Oct 28, 2018

LnL7 commented Oct 28, 2018

ookhoi commented Oct 28, 2018

ookhoi commented Oct 28, 2018

c0bw3b commented Oct 28, 2018

vcunat commented Oct 28, 2018 • edited Loading

vcunat commented Oct 28, 2018

xeji commented Oct 29, 2018

xeji commented Oct 29, 2018

ookhoi commented Nov 3, 2018

ookhoi commented Nov 4, 2018

xeji commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

ookhoi commented Oct 28, 2018 •

edited

Loading

vcunat commented Oct 28, 2018 •

edited

Loading