Revert "NixOS tests: Wait for shell for 10x longer (50m)" #49777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9bc10e1 from #49441
This commit was used to debug the test failures in especially the internally restarting tests. Tests still experience the same timeout, however, with reduced frequency, which is probably due to the other recent efforts in stabilizing Hydra. Here's a recent failure from installer.zfsroot: https://hydra.nixos.org/build/83682241/nixlog/9/tail
This suggests to me that the increased timeout as suspected doesn't actually do anything, because the failure will occur regardless of how long we wait. If that turns out wrong, we can always re-revert, but I think the root cause should be sought elsewhere within the VM test framework.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)