-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.yattag: init at 1.10.1 #51056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the missing license field in the meta
section this seems fine.
meta = with lib; { | ||
description = "Generate HTML or XML in a pythonic way. Pure python alternative to web template engines. Can fill HTML forms with default values and error messages."; | ||
homepage = http://www.yattag.org/; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually want to have a license
field in the meta section for documentation purposes and to prevent possible legal issues in certain setups.
Also, have you thought about adding yourself as maintainer to the package?
@GrahamcOfBorg build pythonPackages.yattag python3Packages.yattag |
Success on aarch64-linux (full log) Attempted: pythonPackages.yattag, python3Packages.yattag Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: pythonPackages.yattag, python3Packages.yattag Partial log (click to expand)
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: pythonPackages.yattag, python3Packages.yattag Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built locally and tested the package's functionality. As the license is now added and the package is fairly trivial (we don't have a hard rule for package maintainers) this seems legit to me 👍
Also, the darwin failures seem to be related to not yet built dependencies (and thus build timeouts). |
Motivation for this change
Adding an HTML generation library I'm using for a project
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)