Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add neovim #5152

Merged
merged 1 commit into from
Nov 28, 2014
Merged

add neovim #5152

merged 1 commit into from
Nov 28, 2014

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Nov 27, 2014

No description provided.

libmsgpack = stdenv.mkDerivation rec {
version = "0.5.9";
name = "libmsgpack-${version}";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library is already in nixpkgs. Why do you need it also here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an experimental version of msgpack, i didn't want to replace the stable version and I'm not sure if neovim will continue to depend on this.

@jagajaga
Copy link
Member

Please squash commits into one.

@manveru
Copy link
Contributor Author

manveru commented Nov 27, 2014

There you go

@jagajaga
Copy link
Member

Check your commit - there is no neovim.

jagajaga added a commit that referenced this pull request Nov 28, 2014
@jagajaga jagajaga merged commit c198540 into NixOS:master Nov 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants