Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: 0.82.1 -> 0.83.3 #51622

Merged
merged 1 commit into from
Dec 7, 2018
Merged

home-assistant: 0.82.1 -> 0.83.3 #51622

merged 1 commit into from
Dec 7, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 6, 2018
@dotlambda
Copy link
Member Author

@GrahamcOfBorg test home-assistant

@dotlambda
Copy link
Member Author

@GrahamcOfBorg build nixosTests.home-assistant

@peterhoeg peterhoeg merged commit 728aaf4 into NixOS:master Dec 7, 2018
@peterhoeg
Copy link
Member

Works here!

@dotlambda
Copy link
Member Author

For me too. Sorry I didn't do thorough tests before the previous PR.

@dotlambda dotlambda deleted the home-assistant-0.83 branch March 21, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg peterhoeg approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dotlambda @peterhoeg @GrahamcOfBorg