certbot, acme: 0.24.0 -> 0.30.2 #51690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
eep actually saw a build failure when trying it again, investigating... |
dotlambda
reviewed
Dec 9, 2018
| ]; | ||
|
|
||
| checkInputs = [ nose ]; | ||
| checkInputs = [ nose pytest ]; |
There was a problem hiding this comment.
I think nose is no longer needed.
dtzWill
added
1 - Ready
and removed
2.status: work-in-progress
dotlambda
reviewed
Jan 8, 2019
pkgs/tools/admin/certbot/default.nix
Outdated
| @@ -4,13 +4,13 @@ | |||
|
|
|||
| pythonPackages.buildPythonApplication rec { | |||
There was a problem hiding this comment.
While we're at it, can we use python3Packages?
|
@GrahamcOfBorg build nixosTests.acme |
(same source)
Specifying "source" in sourceRoot isn't ideal (hopefully it doesn't change, again?) but I think this is the preferred way to do this.
* move to python3 * touchup deps
dtzWill
force-pushed
the
update/acme-0.29.1
branch
from
b36c1c0
to
e79e038
Compare
dtzWill
changed the title
|
@GrahamcOfBorg build nixosTests.acme |
dotlambda
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(same source)
Motivation for this change
Have not reviewed changelogs or tested on a server.
Should at least make sure the 'acme' test passes :).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)