Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl-sdr: remove linker-fix.patch, unbreak on darwin #51777

Merged
merged 1 commit into from
Dec 9, 2018

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Dec 9, 2018

Motivation for this change

The linker patch for darwin does not succeed on rtl-sdr-0.6.0. This enables building of rtl-sdr on darwin again.

CC @lukeadams

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

not needed on rtl-sdr-0.6.0
@markuskowa
Copy link
Member Author

@GrahamcOfBorg build rtl-sdr

@markuskowa markuskowa changed the title [WIP] rtl-sdr: remove linker-fix.patch rtl-sdr: remove linker-fix.patch, unbreak on darwin Dec 9, 2018
@markuskowa markuskowa mentioned this pull request Dec 9, 2018
10 tasks
@Mic92 Mic92 merged commit 6195165 into NixOS:master Dec 9, 2018
@markuskowa markuskowa deleted the fix-rtlsdr branch December 10, 2018 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants