Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

railcar: init at 1.0.4 #51838

Merged
merged 2 commits into from
Dec 11, 2018
Merged

railcar: init at 1.0.4 #51838

merged 2 commits into from
Dec 11, 2018

Conversation

spacekookie
Copy link
Member

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

rasendubi
rasendubi reviewed Dec 10, 2018
View reviewed changes
pkgs/applications/virtualization/railcar/default.nix
cargoSha256 = "16f3ys0zzha8l5jdklmrqivl8hmrb9qgqgzcm3jn06v45hls9lan";

buildInputs = [ libseccomp ];
cargoPatches = [ ./cargo-lock.patch ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be a good idea to submit the patch upstream?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See oracle/railcar#44

@spacekookie @alyssais
railcar: init at 1.0.4
7641a13 
Co-authored-by: Alyssa Ross <hi@alyssa.is>
@rasendubi
Copy link
Member

Added inline comment with the reference to the upstream PR.

@GrahamcOfBorg build railcar

@rasendubi rasendubi merged commit ebd47d7 into NixOS:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi left review comments

@dywedir dywedir dywedir left review comments

@veprbl veprbl veprbl left review comments

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spacekookie @rasendubi @veprbl @dywedir @GrahamcOfBorg