Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sublime: add new download url #51949

Merged
merged 1 commit into from
Dec 13, 2018
Merged

sublime: add new download url #51949

merged 1 commit into from
Dec 13, 2018

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Dec 13, 2018 •
edited
Loading

The old one gave a 404. I left it there for if it ever comes back

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Synthetica9
sublime: add new download url
dcb5c0c 
The old one gave a 404. I left it there for if it ever comes back
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Dec 13, 2018
rasendubi
rasendubi approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Checked old URLs give 404 for me, too
  • Checked build on NixOS with sandboxing

@rasendubi rasendubi merged commit 7aad64b into NixOS:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Synthetica9 @rasendubi @GrahamcOfBorg