Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-ethereum: 1.8.19 -> 1.8.20 #51955

Merged
merged 1 commit into from
Dec 13, 2018
Merged

go-ethereum: 1.8.19 -> 1.8.20 #51955

merged 1 commit into from
Dec 13, 2018

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Dec 13, 2018 •
edited
Loading

Motivation for this change

Update to latest geth.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Dec 13, 2018

@GrahamcOfBorg build go-ethereum

@rasendubi rasendubi merged commit feb6c54 into NixOS:master Dec 13, 2018
@asymmetric asymmetric deleted the geth-1.8.20 branch December 14, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asymmetric @Mic92 @rasendubi @GrahamcOfBorg