pagmo2, pythonPackages.pygmo fixes #51959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
reviewed
Dec 14, 2018
dotlambda
reviewed
Dec 14, 2018
|
|
||
| make install | ||
| mv $out/lib/python*/site-packages/pygmo wheel | ||
| mv ${python.sitePackages}/pygmo wheel |
|
Just because this might be of interest to some: This is exactly what we expect as the relevant output of |
Mic92
reviewed
Dec 14, 2018
dotlambda
reviewed
Dec 14, 2018
|
ping @worldofpeace |
|
@dotlambda Sorry I was away for a bit, I'll fix this up and it should be good 👍 |
corrects the library nlopt location as well.
worldofpeace
force-pushed
the
pagmo-pygmo/fixes
branch
2 times, most recently
from
ed0d23e
to
3455953
Compare
|
I would have done it myself but it seems like you disallowed "edits by maintainers". |
Oops, didn't mean to do that 🤣 |
dotlambda
reviewed
Dec 18, 2018
Introduce a `pagmo2WithPython` which overrides the pagmo2 expression and enables the pygmo build. Then hand it over to `buildPythonPackage` by making it the src to produce a usable package.
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.6-ase/versions
worldofpeace
force-pushed
the
pagmo-pygmo/fixes
branch
from
3455953
to
66a6445
Compare
|
Lol ryantm opened #50645 Nov 18 and it's Dec 18 Good to see this finally hit 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix #51399 with @dotlambda change which looked fine.
This change was meant to fix issues with #50645 so I've brought it here as well for testing.
Things done
I've checked that at least that the packages in question would build.