Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runc: migrate to using buildGoPackage #52560

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Dec 20, 2018

Motivation for this change

Part of #52469, make the runc derivation using buildGoPackage 👼
This means runc becomes a multi-output derivation : runc.bin and runc.man.

cc @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This means `runc` becomes a multi-output derivation : `runc.bin` and `runc.man`.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Dec 20, 2018
@Mic92 Mic92 merged commit 6588480 into NixOS:master Dec 20, 2018
@Mic92
Copy link
Member

Mic92 commented Dec 20, 2018

Thanks!

@vdemeester vdemeester deleted the 52469-runc-to-buildgopackage branch December 20, 2018 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants