Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/kerberos: fix evaluation #53806

Merged
merged 1 commit into from
Jan 11, 2019
Merged

nixos/tests/kerberos: fix evaluation #53806

merged 1 commit into from
Jan 11, 2019

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Jan 11, 2019

Motivation for this change

The test is part of release-combined but presently doesn't evaluate.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
  • nix-build nixos/release-combined.nix -A nixos.tests.kerberos.heimdal.x86_64-linux
  • nix-build nixos/release-combined.nix -A nixos.tests.kerberos.mit.x86_64-linux

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jan 11, 2019
@joachifm joachifm merged commit 8ffae68 into NixOS:master Jan 11, 2019
@grahamc
Copy link
Member

grahamc commented Jan 11, 2019

What needs to change in ofborg to fix this? hmm

@pbogdan pbogdan mentioned this pull request Jan 11, 2019
Closed
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/when-is-nixos-updated-and-why-isnt-it/1294/27

@hedning hedning mentioned this pull request Jan 13, 2019
Closed
@pbogdan pbogdan deleted the krb-test-eval branch December 3, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pbogdan @grahamc @nixos-discourse @joachifm @GrahamcOfBorg