Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reaper: 5.961 -> 5.965 #53880

Merged
merged 1 commit into from Jan 13, 2019
Merged

reaper: 5.961 -> 5.965 #53880

merged 1 commit into from Jan 13, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 13, 2019

Motivation for this change

cc @jfrankenau

  1. Bump version
  2. Add gdk to RPATH, so internal libSwell doesn't woe anymore
  3. Add desktop item, so i3-dmenu-desktop finds an entry
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Jan 13, 2019
@jfrankenau
Copy link
Member

Hmm, starting reaper from the CLI immediately results in a segementation fault for me. The desktop file however works fine although both use the same binary.

@ghost
Copy link
Author

ghost commented Jan 13, 2019

@jfrankenau 😕 can't reproduce. What NixOS revision you are on?

@jfrankenau
Copy link
Member

I am on 18.09.1814.33000fe7cab. However, I assume that it picks up an environment variable of mine and therefore fails to start. I will investigate when I find the time. For now, LGTM.

@xeji
Copy link
Contributor

xeji commented Jan 13, 2019

Starts fine here, no segfault.

@xeji xeji merged commit ffbe5af into NixOS:master Jan 13, 2019
@ghost
Copy link
Author

ghost commented Jan 14, 2019

@jfrankenau @xeji thanks!

@ghost ghost deleted the reaper branch January 14, 2019 05:51
voobscout pushed a commit to voobscout/nixpkgs that referenced this pull request Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants