-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.pyvcd: init at 0.1.4 #53947
Conversation
363ac01
to
d9d317b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding yourself to maintainer-list.nix
should be a separate commit. Also, prepend pythonPackages.
to the existing commit's message.
@GrahamcOfBorg build python3.pkgs.pyvcd |
Please add an appropriate |
d9d317b
to
31cd0f8
Compare
Done and tests passing. Thanks for the quick review! |
@GrahamcOfBorg build python2.pkgs.pyvcd python3.pkgs.pyvcd |
By this we mean https://nixos.wiki/wiki/Nix_Package_Manager#Sandbox_builds. |
@dotlambda Thanks for the merge! @worldofpeace I understood this, but when I try to use
|
I'd usually test by checking if the package builds for both python versions
Also noticed in your And then using
You can also just do
|
@worldofpeace Thank you. Yes, those nix-build commands work.
|
Motivation for this change
Add the pyvcd Python package required by some electronic design automation tools.
Things done
sandbox
innix.conf
on non-NixOS) - Can't figure it out. Works fine withnix-shell --pure
.nix-shell -p nox --run "nox-review wip"
./result/bin/
)