Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.munkres: 1.0.6 -> 1.0.12 #53971

Merged
merged 1 commit into from
Jan 14, 2019
Merged

pythonPackages.munkres: 1.0.6 -> 1.0.12 #53971

merged 1 commit into from
Jan 14, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 14, 2019

Motivation for this change
  • fixes
  • re-enable tests
  • fetch from github, no sdist on pypi
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
munkres: 1.0.6 -> 1.0.12
5b823ad 
* re-enable tests
* fetch from github, no sdist on pypi
@dtzWill dtzWill requested a review from FRidh as a code owner January 14, 2019 22:48
@dotlambda dotlambda changed the title munkres: 1.0.6 -> 1.0.12 pythonPackages.munkres: 1.0.6 -> 1.0.12 Jan 14, 2019
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.munkres python3.pkgs.munkres

@dotlambda dotlambda merged commit be445a9 into NixOS:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtzWill @dotlambda @GrahamcOfBorg