Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2019.01.16 -> 2019.01.17 #54275

Merged
merged 1 commit into from
Jan 18, 2019
Merged

youtube-dl: 2019.01.16 -> 2019.01.17 #54275

merged 1 commit into from
Jan 18, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jan 18, 2019

Motivation for this change

Fixes an issue with youtube, see
ytdl-org/youtube-dl#18891

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau mentioned this pull request Jan 18, 2019
Merged
10 tasks
@dotlambda dotlambda merged commit b86ad89 into NixOS:master Jan 18, 2019
@timokau timokau deleted the youtube-dl-fix branch January 18, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

@fpletz fpletz Awaiting requested review from fpletz

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

@Phreedom Phreedom Awaiting requested review from Phreedom

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timokau @dotlambda @GrahamcOfBorg