Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sherpa: 2.2.5 -> 2.2.6 #54520

Merged
merged 1 commit into from
Jan 28, 2019
Merged

sherpa: 2.2.5 -> 2.2.6 #54520

merged 1 commit into from
Jan 28, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jan 23, 2019

Motivation for this change

New bugfix release is out.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Jan 23, 2019
@Mic92
Copy link
Member

Mic92 commented Jan 25, 2019

@GrahamcOfBorg build sherpa

@veprbl veprbl merged commit b8d6cc8 into NixOS:master Jan 28, 2019
@veprbl veprbl deleted the pr/sherpa_2.2.6 branch December 1, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@veprbl @Mic92 @etu @GrahamcOfBorg