Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/lightdm: allow cursor theme customisation. #54706

Merged
merged 1 commit into from
Feb 3, 2019
Merged

nixos/lightdm: allow cursor theme customisation. #54706

merged 1 commit into from
Feb 3, 2019

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Jan 27, 2019 •
edited
Loading

Motivation for this change

Makes it possible to change cursor theme used by lightdm, including changing the cursor size.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Jan 27, 2019
@infinisil
Copy link
Member

Change the commit message to have the "nixos/lightdm: " prefix instead. This looks good to me otherwise.

@GrahamcOfBorg test lightdm

@pbogdan pbogdan changed the title lightdm: allow cursor theme customisation. nixos/lightdm: allow cursor theme customisation. Jan 28, 2019
@pbogdan
Copy link
Member Author

pbogdan commented Jan 28, 2019

Thanks, commit message amended.

@grahamc
Copy link
Member

grahamc commented Jan 28, 2019

@GrahamcOfBorg test lightdm

poke

@infinisil
Copy link
Member

infinisil commented Jan 28, 2019 •
edited
Loading

Oh, apparently the lightdm test was commented out back in d234c64

@fpletz
Copy link
Member

fpletz commented Feb 3, 2019

We have to fix that test soon because lightdm is our default DM now.

@fpletz fpletz merged commit 14dd9ca into NixOS:master Feb 3, 2019
@pbogdan pbogdan deleted the lightdm-cursors branch December 3, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pbogdan @infinisil @grahamc @fpletz @GrahamcOfBorg